From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae3DJ-0002ZC-9I for qemu-devel@nongnu.org; Thu, 10 Mar 2016 11:13:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ae3DF-0001j8-DT for qemu-devel@nongnu.org; Thu, 10 Mar 2016 11:13:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51694) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae3DF-0001j4-94 for qemu-devel@nongnu.org; Thu, 10 Mar 2016 11:13:21 -0500 Date: Thu, 10 Mar 2016 16:13:17 +0000 From: "Daniel P. Berrange" Message-ID: <20160310161317.GX25607@redhat.com> References: <1457544504-8548-1-git-send-email-berrange@redhat.com> <1457544504-8548-2-git-send-email-berrange@redhat.com> <56E19CF4.1090909@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <56E19CF4.1090909@redhat.com> Subject: Re: [Qemu-devel] [PATCH v1 01/21] osdep: fix socket_error() to work with Mingw64 Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Stefan Weil , qemu-devel@nongnu.org, Andrew Baumann On Thu, Mar 10, 2016 at 05:12:36PM +0100, Paolo Bonzini wrote: > > > On 09/03/2016 18:28, Daniel P. Berrange wrote: > > + case WSAEWOULDBLOCK: > > + return EWOULDBLOCK; > > On mingw EAGAIN != EWOULDBLOCK. Can you instead return EAGAIN here, so > that we can get rid of the "... || errno == EWOULDBLOCK" everywhere? Oh yes, that's a good idea. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|