From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae4Mr-00026A-NI for qemu-devel@nongnu.org; Thu, 10 Mar 2016 12:27:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ae4Mn-0001Xm-RL for qemu-devel@nongnu.org; Thu, 10 Mar 2016 12:27:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae4Mn-0001Wj-GR for qemu-devel@nongnu.org; Thu, 10 Mar 2016 12:27:17 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 348CC63140 for ; Thu, 10 Mar 2016 17:27:17 +0000 (UTC) Date: Thu, 10 Mar 2016 17:27:13 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20160310172713.GB16887@work-vm> References: <1456499430-8558-1-git-send-email-berrange@redhat.com> <1456499430-8558-15-git-send-email-berrange@redhat.com> <20160310154613.GH10196@work-vm> <20160310155620.GW25607@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160310155620.GW25607@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 14/27] migration: convert fd socket protocol to use QIOChannel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Amit Shah , qemu-devel@nongnu.org, Juan Quintela * Daniel P. Berrange (berrange@redhat.com) wrote: > On Thu, Mar 10, 2016 at 03:46:14PM +0000, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berrange@redhat.com) wrote: > > > Convert the fd socket migration protocol driver to use > > > QIOChannel and QEMUFileChannel, instead of plain sockets > > > APIs. It can be unconditionally built because the > > > QIOChannel APIs it uses will take care to report suitable > > > error messages if needed. > > > > > > Signed-off-by: Daniel P. Berrange > > > > Reviewed-by: Dr. David Alan Gilbert > > > > (Dependent on the qio_channel_new_fd patch that doesn't seem > > to be there yet). > > It is merged in master actually: > > commit c767ae62b9efb2c9b2a757984ff1b14f89b49249 > Author: Daniel P. Berrange > Date: Wed Feb 3 14:00:28 2016 +0000 > > io: introduce helper for creating channels from file descriptors Oh yes; great. Dave > > > Regards, > Daniel > -- > |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| > |: http://libvirt.org -o- http://virt-manager.org :| > |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| > |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK