From: Peter Xu <peterx@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] usb: fix unbounded stack warning for xhci_dma_write_u32s
Date: Fri, 11 Mar 2016 09:44:52 +0800 [thread overview]
Message-ID: <20160311014452.GA4976@pxdev.xzpeter.org> (raw)
In-Reply-To: <1457601705.6405.48.camel@redhat.com>
On Thu, Mar 10, 2016 at 10:21:45AM +0100, Gerd Hoffmann wrote:
> On Do, 2016-03-10 at 15:56 +0800, Peter Xu wrote:
> > As mentioned in previous thread, because all the callers of
> > xhci_dma_write_u32s() are using const size in "len". The maximum
> > currently is 5 * sizeof(uint32_t) = 20 bytes
>
> Can you note that in the commit message please?
Sure!
>
> > . Here I choose number
> > bigger than 5 should work for now.
>
> Why bigger? 5 should do just fine then, and the assert added should
> make sure we'll notice if this needs an update due to code changes
> elsewhere.
Will repost with 5.
Thanks.
Peter
prev parent reply other threads:[~2016-03-11 1:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 2:11 [Qemu-devel] [PATCH] usb: fix unbounded stack warning for xhci_dma_write_u32s Peter Xu
2016-03-10 7:34 ` Gerd Hoffmann
2016-03-10 7:56 ` Peter Xu
2016-03-10 9:21 ` Gerd Hoffmann
2016-03-11 1:44 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311014452.GA4976@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).