From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeKpS-0000gL-L2 for qemu-devel@nongnu.org; Fri, 11 Mar 2016 06:02:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aeKpR-00038j-Ro for qemu-devel@nongnu.org; Fri, 11 Mar 2016 06:01:58 -0500 Date: Fri, 11 Mar 2016 11:01:47 +0000 From: Stefan Hajnoczi Message-ID: <20160311110147.GE6523@stefanha-x1.localdomain> References: <1457638209-14218-1-git-send-email-rutu.shah.26@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CGDBiGfvSTbxKZlW" Content-Disposition: inline In-Reply-To: <1457638209-14218-1-git-send-email-rutu.shah.26@gmail.com> Subject: Re: [Qemu-devel] [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: rutu.shah.26@gmail.com Cc: peter.maydell@linaro.org, kvm@vger.kernel.org, mst@redhat.com, jasowang@redhat.com, mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org, lcapitulino@redhat.com, kraxel@redhat.com, qemu-block@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com, samuel.thibault@ens-lyon.org, alistair.francis@xilinx.com, qemu-arm@nongnu.org, pbonzini@redhat.com, cornelia.huck@de.ibm.com, jsnow@redhat.com, rth@twiddle.net, kwolf@redhat.com, crosthwaite.peter@gmail.com, armbru@redhat.com, blauwirbel@gmail.co, qemu-ppc@nongnu.org, imammedo@redhat.com --CGDBiGfvSTbxKZlW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 11, 2016 at 01:00:09AM +0530, rutu.shah.26@gmail.com wrote: > From: Rutuja Shah Hi Rutuja, In addition to the commit message/description issue that Eric raised, please use scripts/checkpatch.pl to check if your changes cause lines to exceed 80 characters. QEMU coding style is 80 characters per line max. Patches should not introduce new violations in existing code that follows the coding style. It might be simplest to address all 80 character line warnings from checkpatch.pl, even if the existing code already exceeded 80 characters. Thanks, Stefan --CGDBiGfvSTbxKZlW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJW4qWbAAoJEJykq7OBq3PIKGoIAK+RxOz8vJ9y4UJOFWIRCZQP pCdtBN5bb4wVxo6uv2rTwINmrCoHfmI+9OzwAO0FEXlgSgkYxx6vw3YMKccEKbTX Vcg8u0M62zuBrdZ3bV72CF78nCdrMwlKKZ+/OXhDqzSa80MzXasUocYV5gUnyUsc Rnevy9DysFVMji0a9bmEADikqFOyDp+EGeSMkWgVs3JbkhFTgVgQOzeBETqhrm46 ICNAmHC1eebYcBp43w/FvZhzw8Pje77gI5vcal45kXzmzmGzFkSbIoqBtc6JlQTx YvsBz7Rx9inqhLDygMK21NuW54DMPH1mq/l4yb4Mbd+qDC0zIk1fwK3W7/IX/g8= =1Xcg -----END PGP SIGNATURE----- --CGDBiGfvSTbxKZlW--