From: Stefan Hajnoczi <stefanha@redhat.com>
To: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org,
igor.rubinov@gmail.com, mark.burton@greensocs.com,
real@ispras.ru, hines@cert.org, qemu-devel@nongnu.org,
maria.klimushenkova@ispras.ru, kwolf@redhat.com,
pbonzini@redhat.com, batuzovk@ispras.ru, alex.bennee@linaro.org,
fred.konrad@greensocs.com
Subject: Re: [Qemu-devel] [PATCH v4 5/5] replay: introduce block devices record/replay
Date: Fri, 11 Mar 2016 13:58:55 +0000 [thread overview]
Message-ID: <20160311135855.GA26287@stefanha-x1.localdomain> (raw)
In-Reply-To: <20160310115620.4812.87175.stgit@PASHA-ISP>
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
On Thu, Mar 10, 2016 at 02:56:20PM +0300, Pavel Dovgalyuk wrote:
> @@ -135,7 +138,7 @@ void replay_add_event(ReplayAsyncEventKind event_kind,
>
> void replay_bh_schedule_event(QEMUBH *bh)
> {
> - if (replay_mode != REPLAY_MODE_NONE) {
> + if (replay_mode != REPLAY_MODE_NONE && events_enabled) {
> uint64_t id = replay_get_current_step();
> replay_add_event(REPLAY_ASYNC_EVENT_BH, bh, NULL, id);
> } else {
Is this hunk a fix that should be in a separate patch or squashed into a
previous patch?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-03-11 13:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 11:55 [Qemu-devel] [PATCH v4 0/5] Deterministic replay extensions Pavel Dovgalyuk
2016-03-10 11:55 ` [Qemu-devel] [PATCH v4 1/5] replay: character devices Pavel Dovgalyuk
2016-03-10 12:24 ` Paolo Bonzini
2016-03-11 6:19 ` Pavel Dovgalyuk
2016-03-11 10:06 ` Paolo Bonzini
2016-03-10 11:56 ` [Qemu-devel] [PATCH v4 2/5] icount: remove obsolete warp call Pavel Dovgalyuk
2016-03-10 12:11 ` Paolo Bonzini
2016-03-10 11:56 ` [Qemu-devel] [PATCH v4 3/5] icount: decouple warp calls Pavel Dovgalyuk
2016-03-10 12:10 ` Paolo Bonzini
2016-03-10 13:19 ` Pavel Dovgalyuk
2016-03-10 13:39 ` Paolo Bonzini
2016-03-10 11:56 ` [Qemu-devel] [PATCH v4 4/5] block: add flush callback Pavel Dovgalyuk
2016-03-10 11:56 ` [Qemu-devel] [PATCH v4 5/5] replay: introduce block devices record/replay Pavel Dovgalyuk
2016-03-11 13:58 ` Stefan Hajnoczi [this message]
2016-03-14 5:52 ` Pavel Dovgalyuk
2016-03-11 13:59 ` Stefan Hajnoczi
2016-03-14 5:53 ` Pavel Dovgalyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311135855.GA26287@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=alex.bennee@linaro.org \
--cc=batuzovk@ispras.ru \
--cc=edgar.iglesias@xilinx.com \
--cc=fred.konrad@greensocs.com \
--cc=hines@cert.org \
--cc=igor.rubinov@gmail.com \
--cc=kwolf@redhat.com \
--cc=maria.klimushenkova@ispras.ru \
--cc=mark.burton@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=real@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).