From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeNap-0007rd-CY for qemu-devel@nongnu.org; Fri, 11 Mar 2016 08:59:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aeNak-0001b6-BO for qemu-devel@nongnu.org; Fri, 11 Mar 2016 08:59:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeNak-0001au-6H for qemu-devel@nongnu.org; Fri, 11 Mar 2016 08:58:58 -0500 Date: Fri, 11 Mar 2016 13:58:55 +0000 From: Stefan Hajnoczi Message-ID: <20160311135855.GA26287@stefanha-x1.localdomain> References: <20160310115551.4812.55431.stgit@PASHA-ISP> <20160310115620.4812.87175.stgit@PASHA-ISP> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dDRMvlgZJXvWKvBx" Content-Disposition: inline In-Reply-To: <20160310115620.4812.87175.stgit@PASHA-ISP> Subject: Re: [Qemu-devel] [PATCH v4 5/5] replay: introduce block devices record/replay List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, igor.rubinov@gmail.com, mark.burton@greensocs.com, real@ispras.ru, hines@cert.org, qemu-devel@nongnu.org, maria.klimushenkova@ispras.ru, kwolf@redhat.com, pbonzini@redhat.com, batuzovk@ispras.ru, alex.bennee@linaro.org, fred.konrad@greensocs.com --dDRMvlgZJXvWKvBx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 10, 2016 at 02:56:20PM +0300, Pavel Dovgalyuk wrote: > @@ -135,7 +138,7 @@ void replay_add_event(ReplayAsyncEventKind event_kind, > =20 > void replay_bh_schedule_event(QEMUBH *bh) > { > - if (replay_mode !=3D REPLAY_MODE_NONE) { > + if (replay_mode !=3D REPLAY_MODE_NONE && events_enabled) { > uint64_t id =3D replay_get_current_step(); > replay_add_event(REPLAY_ASYNC_EVENT_BH, bh, NULL, id); > } else { Is this hunk a fix that should be in a separate patch or squashed into a previous patch? --dDRMvlgZJXvWKvBx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJW4s8fAAoJEJykq7OBq3PIxVwIAJJmC91m9OTeXv323YVbV5gx GSCTbqepLDND/v2MkNcvK3IUHOSUHcBXJl6gG15XNtulCw1pHjW3dNYVmr6QUoMH l9soS+tettI/Yj/KcvbGazzkfPVMYqRiY9rnPHtgXB9XhmTgFYQi2ynQ0M5rSgPW FW5Zh827dA5/+Y50bg8ynGs4jesuFbxbNPE557M7kYstTl7qSAtRSb+7tHCf3VUM YEyVbUAH2EmwEPV0nLvTebDi3kMr0sph6T7d8K3e+SRab72iVPMqDDcZMOEyncHK OWNseaypLPEOsqvj2v9hJkzWvL4wfDh/FLMsI2scd3zrtx38Zd7HpuwEARZDW90= =jzJH -----END PGP SIGNATURE----- --dDRMvlgZJXvWKvBx--