qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kashyap Chamarthy <kchamart@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] input-linux: switch over to -object
Date: Fri, 11 Mar 2016 15:38:23 +0100	[thread overview]
Message-ID: <20160311143823.GC5450@tesla.redhat.com> (raw)
In-Reply-To: <56E29778.9080906@redhat.com>

On Fri, Mar 11, 2016 at 11:01:28AM +0100, Paolo Bonzini wrote:
> 
> 
> On 11/03/2016 08:38, Gerd Hoffmann wrote:
> > This patches makes input-linux use -object instead a new command line

Nit: s/instead a/instead of a/

[If you want to fix up when you apply.]

> > switch.  So, instead of the switch ...
> > 
> >     -input-linux /dev/input/event$nr
> > 
> > ... you must create an object this way:
> > 
> >     -object input-linux,id=$name,evdev=/dev/input/event$nr
> > 
> > Bonus is that you can hot-add and hot-remove them via monitor now.
> > 
> > Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> Great, thank you very much!
> 
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> 

-- 
/kashyap

      reply	other threads:[~2016-03-11 14:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-11  7:38 [Qemu-devel] [PATCH] input-linux: switch over to -object Gerd Hoffmann
2016-03-11 10:01 ` Paolo Bonzini
2016-03-11 14:38   ` Kashyap Chamarthy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160311143823.GC5450@tesla.redhat.com \
    --to=kchamart@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).