From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeOD4-000377-0G for qemu-devel@nongnu.org; Fri, 11 Mar 2016 09:38:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aeOCy-0006IR-St for qemu-devel@nongnu.org; Fri, 11 Mar 2016 09:38:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeOCy-0006IG-Nl for qemu-devel@nongnu.org; Fri, 11 Mar 2016 09:38:28 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 4321064456 for ; Fri, 11 Mar 2016 14:38:27 +0000 (UTC) Date: Fri, 11 Mar 2016 15:38:23 +0100 From: Kashyap Chamarthy Message-ID: <20160311143823.GC5450@tesla.redhat.com> References: <1457681901-30916-1-git-send-email-kraxel@redhat.com> <56E29778.9080906@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56E29778.9080906@redhat.com> Subject: Re: [Qemu-devel] [PATCH] input-linux: switch over to -object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Gerd Hoffmann , qemu-devel@nongnu.org On Fri, Mar 11, 2016 at 11:01:28AM +0100, Paolo Bonzini wrote: > > > On 11/03/2016 08:38, Gerd Hoffmann wrote: > > This patches makes input-linux use -object instead a new command line Nit: s/instead a/instead of a/ [If you want to fix up when you apply.] > > switch. So, instead of the switch ... > > > > -input-linux /dev/input/event$nr > > > > ... you must create an object this way: > > > > -object input-linux,id=$name,evdev=/dev/input/event$nr > > > > Bonus is that you can hot-add and hot-remove them via monitor now. > > > > Suggested-by: Paolo Bonzini > > Signed-off-by: Gerd Hoffmann > > Great, thank you very much! > > Reviewed-by: Paolo Bonzini > -- /kashyap