From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afney-0000wr-FV for qemu-devel@nongnu.org; Tue, 15 Mar 2016 08:01:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afnev-00048a-7D for qemu-devel@nongnu.org; Tue, 15 Mar 2016 08:01:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50453) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afnev-00048N-1w for qemu-devel@nongnu.org; Tue, 15 Mar 2016 08:01:09 -0400 Date: Tue, 15 Mar 2016 12:01:04 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20160315120103.GA11728@work-vm> References: <1458011856-44711-1-git-send-email-aik@ozlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458011856-44711-1-git-send-email-aik@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH qemu] vmstate: Define VARRAY with VMS_ALLOC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Juan Quintela , qemu-devel@nongnu.org, David Gibson * Alexey Kardashevskiy (aik@ozlabs.ru) wrote: > This allows dynamic allocation for migrating arrays. > > Already existing VMSTATE_VARRAY_UINT32 requires an array to be > pre-allocated, however there are cases when the size is not known in > advance and there is no real need to enforce it. > > This defines another variant of VMSTATE_VARRAY_UINT32 with WMS_ALLOC > flag which tells the receiving side to allocate memory for the array > before receiving the data. > > The first user of it is the "pseries" machine (POWER8) with > dynamic DMA windows which existence and size are totally dynamic. You say totally dynamic, how big do they get out of interest? Dave > > Signed-off-by: Alexey Kardashevskiy > Reviewed-by: David Gibson > Reviewed-by: Thomas Huth > --- > > > As David suggested, I am posting it alone (separately from the DDW patchset). > > It would be nice either to get "ack" to get this pulled via the powerpc > tree or get it pulled to the upstream via some other tree. Thanks! > > > > --- > include/migration/vmstate.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h > index 84ee355..1622638 100644 > --- a/include/migration/vmstate.h > +++ b/include/migration/vmstate.h > @@ -386,6 +386,16 @@ extern const VMStateInfo vmstate_info_bitmap; > .offset = vmstate_offset_pointer(_state, _field, _type), \ > } > > +#define VMSTATE_VARRAY_UINT32_ALLOC(_field, _state, _field_num, _version, _info, _type) {\ > + .name = (stringify(_field)), \ > + .version_id = (_version), \ > + .num_offset = vmstate_offset_value(_state, _field_num, uint32_t),\ > + .info = &(_info), \ > + .size = sizeof(_type), \ > + .flags = VMS_VARRAY_UINT32|VMS_POINTER|VMS_ALLOC, \ > + .offset = vmstate_offset_pointer(_state, _field, _type), \ > +} > + > #define VMSTATE_VARRAY_UINT16_UNSAFE(_field, _state, _field_num, _version, _info, _type) {\ > .name = (stringify(_field)), \ > .version_id = (_version), \ > -- > 2.5.0.rc3 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK