qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, Corey Minyard <cminyard@mvista.com>
Subject: Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/
Date: Tue, 15 Mar 2016 16:27:27 +0200	[thread overview]
Message-ID: <20160315162548-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1458051901.13231.78.camel@redhat.com>

On Tue, Mar 15, 2016 at 03:25:01PM +0100, Gerd Hoffmann wrote:
> On Di, 2016-03-15 at 15:14 +0100, Paolo Bonzini wrote:
> > 
> > On 15/03/2016 14:55, Michael S. Tsirkin wrote:
> > > Allowing arbitary file names on command line is setting us up for
> > > failure: future guests will look for a specific QEMU-specified name and
> > > will get confused finding a user file there.
> > > 
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > 
> > Too bad for the user.
> > 
> > I think we have already gone through this discussion.
> 
> Indeed, we discussed that before.
> 
> If users ignore the warning it's their fault.

Everyone ignores warnings. So it's user's fault for using QEMU.

> Being able to set entries outside opt/ can be useful for debugging and
> development purposes, this is the reason it is a warning only and not a
> hard error.
> 
> cheers,
>   Gerd

Add an unsupported flag there then. We have the rule that
flags starting with x- are for internal purposes, use that.
"x-unsupported-fw-cfg"? Don't trap users into
using a feature and then blaming them.

  reply	other threads:[~2016-03-15 14:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-15 13:55 [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/ Michael S. Tsirkin
2016-03-15 14:14 ` Paolo Bonzini
2016-03-15 14:25   ` Gerd Hoffmann
2016-03-15 14:27     ` Michael S. Tsirkin [this message]
2016-03-15 14:25   ` Michael S. Tsirkin
2016-03-15 14:46     ` Gerd Hoffmann
2016-03-15 14:54       ` Michael S. Tsirkin
2016-03-15 15:03         ` Gerd Hoffmann
2016-03-15 15:05           ` Michael S. Tsirkin
2016-03-15 14:54     ` Paolo Bonzini
2016-03-15 14:58       ` Michael S. Tsirkin
2016-03-17  1:31         ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160315162548-mutt-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=cminyard@mvista.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).