From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47600)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1afpwc-0006qd-1a
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:27:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1afpwY-0004bf-Qj
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:27:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42840)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1afpwY-0004bW-LE
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:27:30 -0400
Date: Tue, 15 Mar 2016 16:27:27 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20160315162548-mutt-send-email-mst@redhat.com>
References: <1458050002-27741-1-git-send-email-mst@redhat.com>
	<56E818BD.2080906@redhat.com>
	<1458051901.13231.78.camel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1458051901.13231.78.camel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without
	opt/
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Corey Minyard <cminyard@mvista.com>

On Tue, Mar 15, 2016 at 03:25:01PM +0100, Gerd Hoffmann wrote:
> On Di, 2016-03-15 at 15:14 +0100, Paolo Bonzini wrote:
> > 
> > On 15/03/2016 14:55, Michael S. Tsirkin wrote:
> > > Allowing arbitary file names on command line is setting us up for
> > > failure: future guests will look for a specific QEMU-specified name and
> > > will get confused finding a user file there.
> > > 
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > 
> > Too bad for the user.
> > 
> > I think we have already gone through this discussion.
> 
> Indeed, we discussed that before.
> 
> If users ignore the warning it's their fault.

Everyone ignores warnings. So it's user's fault for using QEMU.

> Being able to set entries outside opt/ can be useful for debugging and
> development purposes, this is the reason it is a warning only and not a
> hard error.
> 
> cheers,
>   Gerd

Add an unsupported flag there then. We have the rule that
flags starting with x- are for internal purposes, use that.
"x-unsupported-fw-cfg"? Don't trap users into
using a feature and then blaming them.