From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afqMe-00016j-No for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:54:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afqMd-0004Rs-Kp for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:54:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afqMd-0004Ro-FB for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:54:27 -0400 Date: Tue, 15 Mar 2016 16:54:23 +0200 From: "Michael S. Tsirkin" Message-ID: <20160315165204-mutt-send-email-mst@redhat.com> References: <1458050002-27741-1-git-send-email-mst@redhat.com> <56E818BD.2080906@redhat.com> <20160315161755-mutt-send-email-mst@redhat.com> <1458053195.13231.92.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458053195.13231.92.camel@redhat.com> Subject: Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Paolo Bonzini , qemu-devel@nongnu.org, Corey Minyard On Tue, Mar 15, 2016 at 03:46:35PM +0100, Gerd Hoffmann wrote: > Hi, > > > > I think we have already gone through this discussion. > > > > So now Corey basically is prevented from sorting sanely > > because command line might not start with opt/ > > Hmm? There are no guarantees whatsoever if the user used the command > line for entries outside /opt. > > Beside that the "sort everything lexical for 2.6+" approach will work > fine. I think it is more robust and I suspect we will have less hassle > with it long-term. > > cheers, > Gerd OK so use built-in order with fallback on lexical, make built-in order empty for 2.6+. Is that fine with you? -- MST