From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afqQz-00049f-Th for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:58:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afqQu-0005fW-U7 for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:58:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41860) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afqQu-0005fM-P8 for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:58:52 -0400 Date: Tue, 15 Mar 2016 16:58:48 +0200 From: "Michael S. Tsirkin" Message-ID: <20160315165509-mutt-send-email-mst@redhat.com> References: <1458050002-27741-1-git-send-email-mst@redhat.com> <56E818BD.2080906@redhat.com> <20160315161755-mutt-send-email-mst@redhat.com> <56E8222C.7090909@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56E8222C.7090909@redhat.com> Subject: Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Corey Minyard , qemu-devel@nongnu.org, Gerd Hoffmann On Tue, Mar 15, 2016 at 03:54:36PM +0100, Paolo Bonzini wrote: > > > On 15/03/2016 15:25, Michael S. Tsirkin wrote: > > Do you look at all warnings all your software prints? > > Yes. I also try to understand them, and if they seem useless I propose > a patch upstream. > > > What if user uses some tool to build the command line? > > > > consider mem-path - for years we printed a warning if > > it's not on hugetlbfs. It worked and users just ignored it. > > That was a bad warning though. There was no reason to warn. > > It was also the smallest problem with the original hugetlbfs patches. > > > So now Corey basically is prevented from sorting sanely > > because command line might not start with opt/ > > Can you explain? > > Paolo Ask Corey: http://thread.gmane.org/gmane.comp.emulators.qemu/400540/focus=400799 -- MST