From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59964)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1afqXY-0007nb-4y
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 11:05:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1afqXW-0008FF-UT
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 11:05:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35316)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1afqXW-0008F7-Pa
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 11:05:42 -0400
Date: Tue, 15 Mar 2016 17:05:38 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20160315170451-mutt-send-email-mst@redhat.com>
References: <1458050002-27741-1-git-send-email-mst@redhat.com>
	<56E818BD.2080906@redhat.com>
	<20160315161755-mutt-send-email-mst@redhat.com>
	<1458053195.13231.92.camel@redhat.com>
	<20160315165204-mutt-send-email-mst@redhat.com>
	<1458054203.13231.96.camel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1458054203.13231.96.camel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without
 opt/
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Corey Minyard <cminyard@mvista.com>

On Tue, Mar 15, 2016 at 04:03:23PM +0100, Gerd Hoffmann wrote:
> On Di, 2016-03-15 at 16:54 +0200, Michael S. Tsirkin wrote:
> > On Tue, Mar 15, 2016 at 03:46:35PM +0100, Gerd Hoffmann wrote:
> > >   Hi,
> > > 
> > > > > I think we have already gone through this discussion.
> > > > 
> > > > So now Corey basically is prevented from sorting sanely
> > > > because command line might not start with opt/
> > > 
> > > Hmm?  There are no guarantees whatsoever if the user used the command
> > > line for entries outside /opt.
> > > 
> > > Beside that the "sort everything lexical for 2.6+" approach will work
> > > fine.  I think it is more robust and I suspect we will have less hassle
> > > with it long-term.
> > > 
> > > cheers,
> > >   Gerd
> > 
> > OK so use built-in order with fallback on lexical,
> 
> I would just call smbios init from the old location for old machine
> types instead of adding code for the built-in sort order ...
> 
> cheers,
>   Gerd

That's too fragile. This time I caught the code reordering
but I might not notice it the next time.

-- 
MST