From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ag06d-00059w-Sn for qemu-devel@nongnu.org; Tue, 15 Mar 2016 21:18:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ag06a-00070d-J5 for qemu-devel@nongnu.org; Tue, 15 Mar 2016 21:18:35 -0400 Date: Wed, 16 Mar 2016 12:04:17 +1100 From: David Gibson Message-ID: <20160316010416.GP9032@voom> References: <1457974600-13828-1-git-send-email-clg@fr.ibm.com> <1457974600-13828-4-git-send-email-clg@fr.ibm.com> <56E70DB3.8080802@redhat.com> <20160315094342.GC9032@voom> <56E7E8BB.5020205@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bvgsfYmVhxWy/2TA" Content-Disposition: inline In-Reply-To: <56E7E8BB.5020205@redhat.com> Subject: Re: [Qemu-devel] [PATCH 03/17] ppc: Add a bunch of hypervisor SPRs to Book3s List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: =?iso-8859-1?Q?C=E9dric?= Le Goater , qemu-ppc@nongnu.org, qemu-devel@nongnu.org --bvgsfYmVhxWy/2TA Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 15, 2016 at 11:49:31AM +0100, Thomas Huth wrote: > On 15.03.2016 10:43, David Gibson wrote: > >=20 > > On Mon, Mar 14, 2016 at 08:14:59PM +0100, Thomas Huth wrote: > >> On 14.03.2016 17:56, C=E9dric Le Goater wrote: > >>> From: Benjamin Herrenschmidt > >>> > >>> We don't give them a KVM reg number to most of the registers yet as no > >>> current KVM version supports HV mode. For DAWR and DAWRX, the KVM reg > >>> number is needed since this register can be set by the guest via the > >>> H_SET_MODE hypercall. > >>> > >>> Signed-off-by: Benjamin Herrenschmidt > >>> [clg: squashed in patch 'ppc: Add KVM numbers to some P8 SPRs' and > >>> changed the commit log with a proposal of Thomas Huth ] > >>> Signed-off-by: C=E9dric Le Goater > >>> --- > >>> target-ppc/translate_init.c | 140 ++++++++++++++++++++++++++++++++++= +++++++++- > >>> 1 file changed, 137 insertions(+), 3 deletions(-) > >>> > >>> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c > >>> index 6a11b41206e5..43c6e524a6bc 100644 > >>> --- a/target-ppc/translate_init.c > >>> +++ b/target-ppc/translate_init.c > >>> @@ -1105,6 +1105,11 @@ static void gen_spr_amr (CPUPPCState *env) > >>> SPR_NOACCESS, SPR_NOACCESS, > >>> &spr_read_generic, &spr_write_generic, > >>> KVM_REG_PPC_UAMOR, 0); > >>> + spr_register_hv(env, SPR_AMOR, "AMOR", > >>> + SPR_NOACCESS, SPR_NOACCESS, > >>> + SPR_NOACCESS, SPR_NOACCESS, > >>> + &spr_read_generic, &spr_write_generic, > >>> + 0); > >>> #endif /* !CONFIG_USER_ONLY */ > >>> } > >>> #endif /* TARGET_PPC64 */ > >>> @@ -7491,6 +7496,20 @@ static void gen_spr_book3s_dbg(CPUPPCState *en= v) > >>> KVM_REG_PPC_DABRX, 0x00000000); > >>> } > >>> =20 > >>> +static void gen_spr_book3s_207_dbg(CPUPPCState *env) > >>> +{ > >>> + spr_register_kvm_hv(env, SPR_DAWR, "DAWR", > >>> + SPR_NOACCESS, SPR_NOACCESS, > >>> + SPR_NOACCESS, SPR_NOACCESS, > >>> + &spr_read_generic, &spr_write_generic, > >>> + KVM_REG_PPC_DAWR, 0x00000000); > >>> + spr_register_kvm_hv(env, SPR_DAWRX, "DAWRX", > >>> + SPR_NOACCESS, SPR_NOACCESS, > >>> + SPR_NOACCESS, SPR_NOACCESS, > >>> + &spr_read_generic, &spr_write_generic, > >>> + KVM_REG_PPC_DAWRX, 0x00000000); > >>> +} > >>> + > >>> static void gen_spr_970_dbg(CPUPPCState *env) > >>> { > >>> /* Breakpoints */ > >>> @@ -7683,15 +7702,116 @@ static void gen_spr_power5p_lpar(CPUPPCState= *env) > >>> spr_register_kvm(env, SPR_LPCR, "LPCR", > >>> SPR_NOACCESS, SPR_NOACCESS, > >>> &spr_read_generic, &spr_write_generic, > >>> - KVM_REG_PPC_LPCR, 0x00000000); > >>> + KVM_REG_PPC_LPCR, LPCR_LPES0 | LPCR_LPES1); > >> > >> Could we please postpone that hunk to a later, separate patch (after > >> QEMU 2.6 has been released)? It looks like it could maybe cause some > >> trouble with some emulated boards (e.g. there is some code in > >> target-ppc/excp_helper.c for example - which is currently disabled, but > >> I'm not sure whether there are other spots like this somewhere else). > >=20 > > I think this whole patch needs to wait until after 2.6, I'm not seeing > > a good rationale for squeezing it into 2.6 at this stage. >=20 > Well, this patch registers DAWR and DAWRX registers with KVM - so > without this patch, the hardware breakpoints will be lost during > migration. I haven't tested it, but I think that when somebody uses > hardware breakpoints in gdb in a KVM guest, and migrates it, then the > breakpoints won't be triggered anymore after migration without this patch. Ah.. good point. So the question becomes, which is lower risk: adjusting the patches to just add DAWR without the HV SPR stuff, or just incorporating the HV SPR stuff as is. > C=E9dric, maybe you could send a patch that adds at least the DAWR and > DAWRX registers if David does not want to have the full patch for 2.6? >=20 > Thomas >=20 >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --bvgsfYmVhxWy/2TA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW6LEQAAoJEGw4ysog2bOSuI8QAI0EsI5PN3RKWNB++zzNF5TK vaN+TN/oBYe021ZcwrtOkoshEUb4dHlF+bsCzYiiKp0B8GppG6PGtA53Fsdl+6B3 tbaaVFtSU7S6U8JkUZk6dCoox9upV1Ht5rACUzPx46ibkyjXyqtSTult88MiD0QQ OdBG0uEwOBRNR8AYknUW6aVXYfq60s5ArL7NoK7AQ9XmTIDhaJ5pgwQwrmS2Z8fJ elbgBHdiIvszEyG/cCjTdENd2lmF8GaHQBsSIvmbONH5w+6LflqFf1HxwEcjAOmb s25i/84b2AzEDG5gXH9YsiWCMfYTK3hfhACICXdbbrSZvo67gj00UGibFYopASq8 09140wjLieq9GrDcxiQZ76SAg3Y/ZrNwlH6YdJcHa4JvUUH0FgpD1jVWuKNnjSl4 odNMigBFhYGhT7rJUu+m16leFS3sPK+UX8QVrnyB7bwgf1Mohtz0mWfO/3jBxXm/ s+xiQNj36KSp3V8xg4ueCPp0s66JsLmXdi4ybccrTd/p79ecw8Bv9ozmrxCkFBR7 ImH86HtKS5khcBi+0NG0RDUmxKtQ8sMe4dp0hq3WMab5v15WEuEBIp2JGI6kycos luG3ZGY2Ve28XPI1zb8mJX+Y0AzOvtg2H1cfg1EN5ySsGE1bIcGVFUj9Eb6qtJFK mJQd8gyu33J6TKnMzMdr =EnuW -----END PGP SIGNATURE----- --bvgsfYmVhxWy/2TA--