From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ag06d-00059x-TK for qemu-devel@nongnu.org; Tue, 15 Mar 2016 21:18:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ag06c-00072d-90 for qemu-devel@nongnu.org; Tue, 15 Mar 2016 21:18:35 -0400 Date: Wed, 16 Mar 2016 12:12:38 +1100 From: David Gibson Message-ID: <20160316011238.GW9032@voom> References: <1457974600-13828-1-git-send-email-clg@fr.ibm.com> <1457974600-13828-15-git-send-email-clg@fr.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CpBQqYjq/d0HQTAP" Content-Disposition: inline In-Reply-To: <1457974600-13828-15-git-send-email-clg@fr.ibm.com> Subject: Re: [Qemu-devel] [PATCH 14/17] ppc: Add dummy write to VTB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: Thomas Huth , qemu-ppc@nongnu.org, qemu-devel@nongnu.org --CpBQqYjq/d0HQTAP Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 14, 2016 at 05:56:37PM +0100, C=E9dric Le Goater wrote: > From: Benjamin Herrenschmidt >=20 > The Hypervisor can write it. We don't handle that properly yet but > at least let's not blow up when it is written. >=20 > Signed-off-by: Benjamin Herrenschmidt AFAICT this should be for 2.7, not 2.6? > --- > target-ppc/translate_init.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) >=20 > diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c > index 2fac6ea58698..28a9c2e73156 100644 > --- a/target-ppc/translate_init.c > +++ b/target-ppc/translate_init.c > @@ -300,6 +300,12 @@ static void spr_write_purr(DisasContext *ctx, int gp= rn, int sprn) > /* Temporary placeholder */ > } > =20 > +__attribute__ ((unused)) > +static void spr_write_vtb(DisasContext *ctx, int gprn, int sprn) > +{ > + /* Temporary placeholder */ > +} > + > #endif > #endif > =20 > @@ -8089,10 +8095,11 @@ static void gen_spr_power8_ebb(CPUPPCState *env) > /* Virtual Time Base */ > static void gen_spr_vtb(CPUPPCState *env) > { > - spr_register(env, SPR_VTB, "VTB", > - SPR_NOACCESS, SPR_NOACCESS, > - &spr_read_tbl, SPR_NOACCESS, > - 0x00000000); > + spr_register_hv(env, SPR_VTB, "VTB", > + SPR_NOACCESS, SPR_NOACCESS, > + &spr_read_tbl, SPR_NOACCESS, > + &spr_read_tbl, spr_write_vtb, > + 0x00000000); > } > =20 > static void gen_spr_power8_fscr(CPUPPCState *env) --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --CpBQqYjq/d0HQTAP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW6LMGAAoJEGw4ysog2bOSnogQAMogX4xzkzK7ZEBtdtHSqqYf vA1tB/x4kYrcN+2c1QKRl7cxnhde8lgABniepmpbKLflnM4cL+Snidw/JiGJH5gV IK3K0yQIcTMonRXcIjphX/BLz1DTXfwuhm766lcDYEUroIfwDjEQRZ1tpZPszP2M mO0YEetZQnTfar0rWfGDChY44oZtzLuTpWDs2Xbd4N1enOCkn/nlbI9VG+uPJXBs hsTZ+PkDnQl/4z97WyqoFHILu7bP8Eq7hvWceC6mWvXgZ3Xm3U4k7AcDcEVqfIDC D+upTxkXxQPwh/ZSc8w7UC1BQBflIEcLCvtMTkSh8ncvcCDBqNDRPNnL2EWrOZWZ l8Hg9oPXAXpB5Vu5Lu3L3CgIIeDXphM0MTAyv2VQRw2eAKuc7YVSG+oN2rjABkM3 +47W0ESRydq0xRp/dSnyLrotj26osdSbrWVTafgOrDRxIMV9gpM/ipJe+VN46YnS omQveia+wzsdnvl93zWLdJJIEu45SfOrjoq/SEdZrTKcaS7Z1iIWCP1eY+pv50OJ Mo57dB8RNAju/+9efJZ29NIFH8MDewz8kD57tRT8wtjT+P5kTex7jgn83d22k1EL 2T1tgpAhiueg25BDY3iOVAwGzrKKr1Y80BozTUNnBopCjF0y27DFob2ZfLgKC0h6 whYPxZJTFyByLGd+C6DR =9bls -----END PGP SIGNATURE----- --CpBQqYjq/d0HQTAP--