From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ag06d-00059y-VK for qemu-devel@nongnu.org; Tue, 15 Mar 2016 21:18:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ag06b-00072E-WE for qemu-devel@nongnu.org; Tue, 15 Mar 2016 21:18:35 -0400 Date: Wed, 16 Mar 2016 12:14:12 +1100 From: David Gibson Message-ID: <20160316011412.GX9032@voom> References: <1457974600-13828-1-git-send-email-clg@fr.ibm.com> <1457974600-13828-16-git-send-email-clg@fr.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8D1TCnBmjJJF2KCx" Content-Disposition: inline In-Reply-To: <1457974600-13828-16-git-send-email-clg@fr.ibm.com> Subject: Re: [Qemu-devel] [PATCH 15/17] ppc: Add dummy POWER8 MPPR register List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: Thomas Huth , qemu-ppc@nongnu.org, qemu-devel@nongnu.org --8D1TCnBmjJJF2KCx Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 14, 2016 at 05:56:38PM +0100, C=E9dric Le Goater wrote: > From: Benjamin Herrenschmidt >=20 > Controls the micropartition prefetch, this is pretty much meaningless > in full emulation (used for priming the caches on real HW). >=20 > Signed-off-by: Benjamin Herrenschmidt So, this is readable with HV=3D0, so technically a fix even for non-HV machines. I'm guessing it's not actually read in practice outside the HV, though. Not sure if this should go in 2.6 or 2.7. > --- > target-ppc/cpu.h | 1 + > target-ppc/translate_init.c | 13 +++++++++++++ > 2 files changed, 14 insertions(+) >=20 > diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h > index 81a3e6b5ed29..5203cc6a3bfb 100644 > --- a/target-ppc/cpu.h > +++ b/target-ppc/cpu.h > @@ -1398,6 +1398,7 @@ static inline int cpu_mmu_index (CPUPPCState *env, = bool ifetch) > #define SPR_DHDES (0x0B1) > #define SPR_DPDES (0x0B0) > #define SPR_DAWR (0x0B4) > +#define SPR_MPPR (0x0B8) > #define SPR_RPR (0x0BA) > #define SPR_DAWRX (0x0BC) > #define SPR_HFSCR (0x0BE) > diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c > index 28a9c2e73156..cfb1bc088950 100644 > --- a/target-ppc/translate_init.c > +++ b/target-ppc/translate_init.c > @@ -8161,6 +8161,18 @@ static void gen_spr_power8_ic(CPUPPCState *env) > #endif > } > =20 > +static void gen_spr_power8_book4(CPUPPCState *env) > +{ > + /* Add a number of P8 book4 registers */ > +#if !defined(CONFIG_USER_ONLY) > + spr_register_hv(env, SPR_MPPR, "MPPR", > + SPR_NOACCESS, SPR_NOACCESS, > + &spr_read_generic, SPR_NOACCESS, > + &spr_read_generic, &spr_write_generic, > + 0); > +#endif > +} > + > static void init_proc_book3s_64(CPUPPCState *env, int version) > { > gen_spr_ne_601(env); > @@ -8216,6 +8228,7 @@ static void init_proc_book3s_64(CPUPPCState *env, i= nt version) > gen_spr_power8_rpr(env); > gen_spr_power8_dbell(env); > gen_spr_power8_ic(env); > + gen_spr_power8_book4(env); > } > if (version < BOOK3S_CPU_POWER8) { > gen_spr_book3s_dbg(env); --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --8D1TCnBmjJJF2KCx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW6LNkAAoJEGw4ysog2bOSCDYQANO7YHEIgfJxbG8FqbGArMwO acseOYRdgM2FNPdDQEd57Exq+CIhUt4DjrerWy4Zv2DS0hs8k3n/WuCRlDZUbQY8 GcMvj24ji1ZNxAlzhBJgmAvr7g2miIzr3swO3uWdLZM+IFSJyBt2BETKn7dwngs0 1T95til8TQrObrG7Zc564T03g/sSU+IDXm7Qai9exmyBTEIkOx/JXNJyb813ZKG2 RHSvSuE9LyNS6pr5INBCseLqrt561AlPl+OWdAABaZyB+JOq2cfHbZzn0xdTCrtE XUCc6UypByBD6fHqfmAt3bD0m+d0aDBjSNqmpMEMoiU/h6TIrgYOmtuoNOeQXKh5 szfAx8YbfxeGpwMS3QYlIZLqmaSM5WwlvwbwN+Bi6ts25bRdIFTVbYmt3RYtXLpi WQl2PFtU6/lRvQVjFeZJYjkv6mBrsuvJaRgcPAPiqIuNro0yghMzcfe4xu0zf+p/ ffLv9F7KB51uzeUV1MqxGeDPPJxubpPZWiuhGs3B/amdwllShNaER8PSOKA5qjfh oszr8b8xkw2+ukfQyDX16o8v69+daZq24IzoUByNiUN36ScSH3uJCwGQk/RtZuFi uR13BtXCPaIkT/JxfN5xS+C3F1yByjvPcrqR0jc86qGbpkeXqTv9SEp9gDgi9Jz5 cySnjpEJ+HNLx7WVH3cY =5c8+ -----END PGP SIGNATURE----- --8D1TCnBmjJJF2KCx--