From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ag3t1-0003ym-27 for qemu-devel@nongnu.org; Wed, 16 Mar 2016 01:20:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ag3sx-0000Uw-RF for qemu-devel@nongnu.org; Wed, 16 Mar 2016 01:20:46 -0400 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:53125) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ag3sx-0000Un-7m for qemu-devel@nongnu.org; Wed, 16 Mar 2016 01:20:43 -0400 Received: from localhost by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 16 Mar 2016 15:20:39 +1000 Date: Wed, 16 Mar 2016 10:49:41 +0530 From: Bharata B Rao Message-ID: <20160316051941.GE13176@in.ibm.com> References: <1458048248-4605-1-git-send-email-imammedo@redhat.com> <1458048248-4605-3-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458048248-4605-3-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [RFC v3 2/2] spapr: implement query-hotpluggable-cpus QMP command Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: mjrosato@linux.vnet.ibm.com, agraf@suse.de, pkrempa@redhat.com, ehabkost@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, borntraeger@de.ibm.com, qemu-ppc@nongnu.org, cornelia.huck@de.ibm.com, dgibson@redhat.com, afaerber@suse.de On Tue, Mar 15, 2016 at 02:24:08PM +0100, Igor Mammedov wrote: > it returns a list of present/possible to hotplug CPU > objects with a list of properties to use with > device_add. > > in spapr case returned list would looks like: > -> { "execute": "query-hotpluggable-cpus" } > <- {"return": [ > { "props": { "core": 1 }, "type": "spapr-cpu-core", > "vcpus-count": 2 }, > { "props": { "core": 0 }, "type": "spapr-cpu-core", > "vcpus-count": 2, > "qom-path": "/machine/unattached/device[0]"} > ]}' > > TODO: > add 'node' property for core <-> numa node mapping > > Signed-off-by: Igor Mammedov > --- > it's only compile tested > --- > hw/ppc/spapr.c | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index b1e9ba2..e1ce983 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -65,6 +65,7 @@ > #include "hw/compat.h" > #include "qemu-common.h" > #include "hw/ppc/spapr_cpu_core.h" > +#include "qmp-commands.h" > > #include > > @@ -2399,6 +2400,37 @@ static unsigned spapr_cpu_index_to_socket_id(unsigned cpu_index) > return cpu_index / smp_threads / smp_cores; > } > > +HotpluggableCPUList *qmp_query_hotpluggable_cpus(Error **errp) > +{ > + int i; > + HotpluggableCPUList *head = NULL; > + sPAPRMachineState *spapr = SPAPR_MACHINE(qdev_get_machine()); > + int spapr_max_cores = max_cpus / smp_threads; > + > + for (i = 0; i < spapr_max_cores; i++) { > + HotpluggableCPUList *list_item = g_new0(typeof(*list_item), 1); > + HotpluggableCPU *cpu_item = g_new0(typeof(*cpu_item), 1); > + CpuInstanceProperties *cpu_props = g_new0(typeof(*cpu_props), 1); > + > + cpu_item->type = g_strdup(TYPE_SPAPR_CPU_CORE); > + cpu_item->vcpus_count = smp_threads; Shouldn't this be fetched from "threads" property of the core device instead of directly using smp_threads ? But again, what that would mean for not-yet-plugged in cores and how to get that for them is a question. Regards, Bharata.