From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36830)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ag8z2-0002uV-7t
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 06:47:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ag8yw-00022W-Ne
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 06:47:20 -0400
Date: Wed, 16 Mar 2016 11:47:08 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20160316104708.GA6111@noname.redhat.com>
References: <1457977061-28087-1-git-send-email-kwolf@redhat.com>
	<1457977061-28087-19-git-send-email-kwolf@redhat.com>
	<56E9384B.1080601@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56E9384B.1080601@redhat.com>
Subject: Re: [Qemu-devel] [PULL 18/40] hmp: 'drive_add -n' for creating a
	node without BB
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org

Am 16.03.2016 um 11:41 hat Paolo Bonzini geschrieben:
> > +void hmp_drive_add_node(Monitor *mon, const char *optstr)
> > +{
> > +    QemuOpts *opts;
> > +    QDict *qdict;
> > +    Error *local_err = NULL;
> > +
> > +    opts = qemu_opts_parse_noisily(&qemu_drive_opts, optstr, false);
> > +    if (!opts) {
> > +        return;
> > +    }
> > +
> > +    qdict = qemu_opts_to_qdict(opts, NULL);
> > +
> > +    if (!qdict_get_try_str(qdict, "node-name")) {
> > +        error_report("'node-name' needs to be specified");
> 
> qdict is leaked here, says Coverity.

I already sent a fix.

Kevin