From: "Michael S. Tsirkin" <mst@redhat.com>
To: Marcel Apfelbaum <marcel@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
imammedo@redhat.com, rth@twiddle.net, qemu-devel@nongnu.org,
ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH] hw/acpi: fix GSI links UID
Date: Wed, 16 Mar 2016 16:03:58 +0200 [thread overview]
Message-ID: <20160316160322-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <56E94EC0.1070809@redhat.com>
On Wed, Mar 16, 2016 at 02:17:04PM +0200, Marcel Apfelbaum wrote:
> On 03/15/2016 07:27 PM, Paolo Bonzini wrote:
> >
> >
> >On 13/03/2016 12:40, Marcel Apfelbaum wrote:
> >>According to the ACPI spec, each UID must be unique.
> >>Use the irq number as UID for GSI links.
> >>
> >>Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> >>Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
> >
> >This causes a warning from acpi-test. The diff is
> >
> >2720c2720
> >< Name (_UID, Zero) // _UID: Unique ID
> >---
> >> Name (_UID, 0x10) // _UID: Unique ID
> >2747c2747
> >< Name (_UID, Zero) // _UID: Unique ID
> >---
> >> Name (_UID, 0x11) // _UID: Unique ID
> >2774c2774
> >< Name (_UID, Zero) // _UID: Unique ID
> >---
> >> Name (_UID, 0x12) // _UID: Unique ID
> >2801c2801
> >< Name (_UID, Zero) // _UID: Unique ID
> >---
> >> Name (_UID, 0x13) // _UID: Unique ID
> >2828c2828
> >< Name (_UID, Zero) // _UID: Unique ID
> >---
> >> Name (_UID, 0x14) // _UID: Unique ID
> >2855c2855
> >< Name (_UID, Zero) // _UID: Unique ID
> >---
> >> Name (_UID, 0x15) // _UID: Unique ID
> >2882c2882
> >< Name (_UID, Zero) // _UID: Unique ID
> >---
> >> Name (_UID, 0x16) // _UID: Unique ID
> >2909c2909
> >< Name (_UID, Zero) // _UID: Unique ID
> >---
> >> Name (_UID, 0x17) // _UID: Unique ID
> >
> >I think you should have updated tests/acpi-test-data.
>
> Thanks Paolo, you are right.
>
> I am "used to" Michael updating the test data on his pull request.
> I can send an update myself, it will have to wait a few days.
>
> Thanks,
> Marcel
>
> >
> >Paolo
> >
True, I forgot to include this in the pull request.
Fixed, upstream is fine now.
Thanks for the reminder!
--
MST
prev parent reply other threads:[~2016-03-16 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-13 11:40 [Qemu-devel] [PATCH] hw/acpi: fix GSI links UID Marcel Apfelbaum
2016-03-14 9:43 ` Igor Mammedov
2016-03-15 17:27 ` Paolo Bonzini
2016-03-16 12:17 ` Marcel Apfelbaum
2016-03-16 14:03 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160316160322-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).