From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38877)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1agC3S-0008Is-Ng
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 10:04:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1agC3P-0001zu-Hv
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 10:04:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53515)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1agC3P-0001zq-DA
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 10:04:03 -0400
Date: Wed, 16 Mar 2016 16:03:58 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20160316160322-mutt-send-email-mst@redhat.com>
References: <1457869229-9989-1-git-send-email-marcel@redhat.com>
	<56E8461C.6030306@redhat.com> <56E94EC0.1070809@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56E94EC0.1070809@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] hw/acpi: fix GSI links UID
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcel Apfelbaum <marcel@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, imammedo@redhat.com, rth@twiddle.net, qemu-devel@nongnu.org, ehabkost@redhat.com

On Wed, Mar 16, 2016 at 02:17:04PM +0200, Marcel Apfelbaum wrote:
> On 03/15/2016 07:27 PM, Paolo Bonzini wrote:
> >
> >
> >On 13/03/2016 12:40, Marcel Apfelbaum wrote:
> >>According to the ACPI spec, each UID must be unique.
> >>Use the irq number as UID for GSI links.
> >>
> >>Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> >>Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
> >
> >This causes a warning from acpi-test.  The diff is
> >
> >2720c2720
> ><             Name (_UID, Zero)  // _UID: Unique ID
> >---
> >>             Name (_UID, 0x10)  // _UID: Unique ID
> >2747c2747
> ><             Name (_UID, Zero)  // _UID: Unique ID
> >---
> >>             Name (_UID, 0x11)  // _UID: Unique ID
> >2774c2774
> ><             Name (_UID, Zero)  // _UID: Unique ID
> >---
> >>             Name (_UID, 0x12)  // _UID: Unique ID
> >2801c2801
> ><             Name (_UID, Zero)  // _UID: Unique ID
> >---
> >>             Name (_UID, 0x13)  // _UID: Unique ID
> >2828c2828
> ><             Name (_UID, Zero)  // _UID: Unique ID
> >---
> >>             Name (_UID, 0x14)  // _UID: Unique ID
> >2855c2855
> ><             Name (_UID, Zero)  // _UID: Unique ID
> >---
> >>             Name (_UID, 0x15)  // _UID: Unique ID
> >2882c2882
> ><             Name (_UID, Zero)  // _UID: Unique ID
> >---
> >>             Name (_UID, 0x16)  // _UID: Unique ID
> >2909c2909
> ><             Name (_UID, Zero)  // _UID: Unique ID
> >---
> >>             Name (_UID, 0x17)  // _UID: Unique ID
> >
> >I think you should have updated tests/acpi-test-data.
> 
> Thanks Paolo, you are right.
> 
> I am "used to" Michael updating the test data on his pull request.
> I can send an update myself, it will have to wait a few days.
> 
> Thanks,
> Marcel
> 
> >
> >Paolo
> >

True, I forgot to include this in the pull request.
Fixed, upstream is fine now.

Thanks for the reminder!

-- 
MST