* [Qemu-devel] [PATCH] qemu-ga: drop unused local err variable
@ 2016-03-16 15:16 Stefan Hajnoczi
2016-03-17 2:18 ` Fam Zheng
2016-03-17 21:13 ` Michael Roth
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2016-03-16 15:16 UTC (permalink / raw)
To: qemu-devel; +Cc: Michael Roth, Stefan Hajnoczi
Commit 125b310e1d62e3a1dc1e7758563e598957ca7ae4 ("qemu-ga: move
channel/transport functionality into wrapper class") stopped using the
local err variable in channel_event_cb().
This patch deletes the unused variable.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
qga/main.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/qga/main.c b/qga/main.c
index 0a168e2..743c5c1 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -618,13 +618,7 @@ static gboolean channel_event_cb(GIOCondition condition, gpointer data)
GAState *s = data;
gchar buf[QGA_READ_COUNT_DEFAULT+1];
gsize count;
- GError *err = NULL;
GIOStatus status = ga_channel_read(s->channel, buf, QGA_READ_COUNT_DEFAULT, &count);
- if (err != NULL) {
- g_warning("error reading channel: %s", err->message);
- g_error_free(err);
- return false;
- }
switch (status) {
case G_IO_STATUS_ERROR:
g_warning("error reading channel");
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-ga: drop unused local err variable
2016-03-16 15:16 [Qemu-devel] [PATCH] qemu-ga: drop unused local err variable Stefan Hajnoczi
@ 2016-03-17 2:18 ` Fam Zheng
2016-03-17 21:13 ` Michael Roth
1 sibling, 0 replies; 3+ messages in thread
From: Fam Zheng @ 2016-03-17 2:18 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: qemu-devel, Michael Roth
On Wed, 03/16 15:16, Stefan Hajnoczi wrote:
> Commit 125b310e1d62e3a1dc1e7758563e598957ca7ae4 ("qemu-ga: move
> channel/transport functionality into wrapper class") stopped using the
> local err variable in channel_event_cb().
>
> This patch deletes the unused variable.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> qga/main.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/qga/main.c b/qga/main.c
> index 0a168e2..743c5c1 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -618,13 +618,7 @@ static gboolean channel_event_cb(GIOCondition condition, gpointer data)
> GAState *s = data;
> gchar buf[QGA_READ_COUNT_DEFAULT+1];
> gsize count;
> - GError *err = NULL;
> GIOStatus status = ga_channel_read(s->channel, buf, QGA_READ_COUNT_DEFAULT, &count);
> - if (err != NULL) {
> - g_warning("error reading channel: %s", err->message);
> - g_error_free(err);
> - return false;
> - }
> switch (status) {
> case G_IO_STATUS_ERROR:
> g_warning("error reading channel");
> --
> 2.5.0
>
>
Reviewed-by: Fam Zheng <famz@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-ga: drop unused local err variable
2016-03-16 15:16 [Qemu-devel] [PATCH] qemu-ga: drop unused local err variable Stefan Hajnoczi
2016-03-17 2:18 ` Fam Zheng
@ 2016-03-17 21:13 ` Michael Roth
1 sibling, 0 replies; 3+ messages in thread
From: Michael Roth @ 2016-03-17 21:13 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel
Quoting Stefan Hajnoczi (2016-03-16 10:16:02)
> Commit 125b310e1d62e3a1dc1e7758563e598957ca7ae4 ("qemu-ga: move
> channel/transport functionality into wrapper class") stopped using the
> local err variable in channel_event_cb().
>
> This patch deletes the unused variable.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Thanks, applied to qga tree:
https://github.com/mdroth/qemu/commits/qga
> ---
> qga/main.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/qga/main.c b/qga/main.c
> index 0a168e2..743c5c1 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -618,13 +618,7 @@ static gboolean channel_event_cb(GIOCondition condition, gpointer data)
> GAState *s = data;
> gchar buf[QGA_READ_COUNT_DEFAULT+1];
> gsize count;
> - GError *err = NULL;
> GIOStatus status = ga_channel_read(s->channel, buf, QGA_READ_COUNT_DEFAULT, &count);
> - if (err != NULL) {
> - g_warning("error reading channel: %s", err->message);
> - g_error_free(err);
> - return false;
> - }
> switch (status) {
> case G_IO_STATUS_ERROR:
> g_warning("error reading channel");
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-17 21:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-16 15:16 [Qemu-devel] [PATCH] qemu-ga: drop unused local err variable Stefan Hajnoczi
2016-03-17 2:18 ` Fam Zheng
2016-03-17 21:13 ` Michael Roth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).