From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58977)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1agPFt-0007Xu-GM
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 00:09:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1agPFs-0007hc-Kr
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 00:09:49 -0400
Date: Thu, 17 Mar 2016 12:09:35 +0800
From: Peter Xu <peterx@redhat.com>
Message-ID: <20160317040935.GE23495@pxdev.xzpeter.org>
References: <1457422582-28799-1-git-send-email-peterx@redhat.com>
	<1457422582-28799-3-git-send-email-peterx@redhat.com>
	<CAFEAcA9jCwLnG5QKTG9Hd+r8tVYSN6A8dwWp2JMPV1rMUAAjLQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAFEAcA9jCwLnG5QKTG9Hd+r8tVYSN6A8dwWp2JMPV1rMUAAjLQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v4 2/3] arm: qmp: add
	query-gic-capabilities interface
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Wei Huang <wei@redhat.com>, Andrew Jones <drjones@redhat.com>, Markus Armbruster <armbru@redhat.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, QEMU Developers <qemu-devel@nongnu.org>, qemu-arm <qemu-arm@nongnu.org>, Andrea Bolognani <abologna@redhat.com>

On Wed, Mar 16, 2016 at 10:24:39AM +0000, Peter Maydell wrote:
> On 8 March 2016 at 07:36, Peter Xu <peterx@redhat.com> wrote:
> > diff --git a/target-arm/machine.c b/target-arm/machine.c
> > index 03a73d9..813909e 100644
> > --- a/target-arm/machine.c
> > +++ b/target-arm/machine.c
> > @@ -5,6 +5,7 @@
> >  #include "sysemu/kvm.h"
> >  #include "kvm_arm.h"
> >  #include "internals.h"
> > +#include "qmp-commands.h"
> >
> >  static bool vfp_needed(void *opaque)
> >  {
> > @@ -345,3 +346,8 @@ const char *gicv3_class_name(void)
> >
> >      exit(1);
> >  }
> > +
> > +GICCapabilityList *qmp_query_gic_capabilities(Error **errp)
> > +{
> > +    return NULL;
> > +}
> 
> Why is this here? machine.c is for migration code.

Hi, Peter,

Thanks for the review comments. Do you have any suggestion on which
file should I add this in (or create a new one)? I failed to figure
it out myself. :(

TIA.

-- peterx