From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54384) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agUgn-0007We-Nt for qemu-devel@nongnu.org; Thu, 17 Mar 2016 05:57:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agUgk-0002St-Hi for qemu-devel@nongnu.org; Thu, 17 Mar 2016 05:57:57 -0400 Date: Thu, 17 Mar 2016 17:27:15 +1100 From: David Gibson Message-ID: <20160317062715.GQ9032@voom> References: <1458130611-17304-1-git-send-email-thuth@redhat.com> <1458130611-17304-4-git-send-email-thuth@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="edOgkofft1yGJ5kl" Content-Disposition: inline In-Reply-To: <1458130611-17304-4-git-send-email-thuth@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/3] hw/net/spapr_llan: Enable the RX buffer pools by default for new machines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: lvivier@redhat.com, Alexey Kardashevskiy , Jason Wang , qemu-devel@nongnu.org, Alexander Graf , qemu-ppc@nongnu.org, Anton Blanchard --edOgkofft1yGJ5kl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 16, 2016 at 01:16:51PM +0100, Thomas Huth wrote: > RX buffer pools are now enabled by default for new machine types. > For older machine types, they are still disabled to avoid breaking > migration. >=20 > Signed-off-by: Thomas Huth Reviewed-by: David Gibson > --- > hw/net/spapr_llan.c | 2 +- > hw/ppc/spapr.c | 7 ++++++- > 2 files changed, 7 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/net/spapr_llan.c b/hw/net/spapr_llan.c > index 74c8b1e..4e28b89 100644 > --- a/hw/net/spapr_llan.c > +++ b/hw/net/spapr_llan.c > @@ -709,7 +709,7 @@ static Property spapr_vlan_properties[] =3D { > DEFINE_SPAPR_PROPERTIES(VIOsPAPRVLANDevice, sdev), > DEFINE_NIC_PROPERTIES(VIOsPAPRVLANDevice, nicconf), > DEFINE_PROP_BIT("use-rx-buffer-pools", VIOsPAPRVLANDevice, > - compat_flags, SPAPRVLAN_FLAG_RX_BUF_POOLS_BIT, false= ), > + compat_flags, SPAPRVLAN_FLAG_RX_BUF_POOLS_BIT, true), > DEFINE_PROP_END_OF_LIST(), > }; > =20 > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 79a70a9..50d5a62 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -2362,7 +2362,12 @@ DEFINE_SPAPR_MACHINE(2_6, "2.6", true); > * pseries-2.5 > */ > #define SPAPR_COMPAT_2_5 \ > - HW_COMPAT_2_5 > + HW_COMPAT_2_5 \ > + { \ > + .driver =3D "spapr-vlan", \ > + .property =3D "use-rx-buffer-pools", \ > + .value =3D "off", \ > + }, > =20 > static void spapr_machine_2_5_instance_options(MachineState *machine) > { --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --edOgkofft1yGJ5kl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW6k5DAAoJEGw4ysog2bOSqUUQAJY0b/XngtiU/EAf1fwYH6qk 4gEXyToSKRB8Q2PU6Yb4jn5RbbaaYrJxOzZA4rXKPIV8FWyg1fhOP0Xl4eSgbN/v RB3LHD6m8muo/B5UDVzoLSQvk66OefVIu9vcrwlKWAPVUPU0xr+71pKMV3u0ZIhL CxFk4Zaem1D6OZAzlKW5cFGDTCkpFRWfQbbBP3iVw66LND0TGGG4C+AY4fqxCidL Ju/aiaLPh0jB1C8htOCcgUB5MWuGCjLBknHqKUMhJy8VZfsMdTB+UJO4/5WwB6gl zCHUhA2H6Y24MAPs56YPmpxXH1pIVZwGKUbDc/6IunG5P8UK+tNF6TlWA4t+9hXw RgY8h1eykFVZRkxKSOdT8JsYWvltfkOzrpPpfeOyD4SdZOHtjol0ffnKQxvEKsgo UIa0IRdpFm7LRxjHh5HeqBMpkGeCQV49az9u0Up/v1GAiI+tYadSsqlK2TAnqtTQ 8gMLozegUQvrmbz6Hs0mV8pt5nr9bFezRw6nh40WRt/Rp3W8rYMBRsa4UO0CPTrg 6B5N+aHAOyqdxeIE1desV1w3acHZFm94iOBOeLQo2Kff5tCjJaJYx5LEzaFfpFKM mtoodYcLnKfRmWQbLNvCQX59+jdrN/771fgkNQEJ6NRwQa03jhsoLW2D6FUnCEo+ qTJClW9viGimsXkrpGWU =Ytnq -----END PGP SIGNATURE----- --edOgkofft1yGJ5kl--