From: Peter Xu <peterx@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Wei Huang <wei@redhat.com>, Andrew Jones <drjones@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>,
QEMU Developers <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>,
Andrea Bolognani <abologna@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 2/3] arm: qmp: add query-gic-capabilities interface
Date: Thu, 17 Mar 2016 17:09:27 +0800 [thread overview]
Message-ID: <20160317090927.GG23495@pxdev.xzpeter.org> (raw)
In-Reply-To: <CAFEAcA-jzgMHH0=sMqv8+NB2=xgEP-0jWmYzP0M1om=8uDR6Lw@mail.gmail.com>
On Thu, Mar 17, 2016 at 08:50:38AM +0000, Peter Maydell wrote:
> On 17 March 2016 at 04:09, Peter Xu <peterx@redhat.com> wrote:
> > Thanks for the review comments. Do you have any suggestion on which
> > file should I add this in (or create a new one)? I failed to figure
> > it out myself. :(
>
> I suggest target-arm/monitor.c (we have a monitor.c for other
> target-* already for monitor related functions).
Will take your advice and respin. Thanks!
-- peterx
next prev parent reply other threads:[~2016-03-17 9:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 7:36 [Qemu-devel] [PATCH v4 0/3] ARM: add query-gic-capabilities SMP command Peter Xu
2016-03-08 7:36 ` [Qemu-devel] [PATCH v4 1/3] arm: qmp: add GICCapability struct Peter Xu
2016-03-08 7:36 ` [Qemu-devel] [PATCH v4 2/3] arm: qmp: add query-gic-capabilities interface Peter Xu
2016-03-16 10:24 ` Peter Maydell
2016-03-17 4:09 ` Peter Xu
2016-03-17 8:50 ` Peter Maydell
2016-03-17 9:09 ` Peter Xu [this message]
2016-03-08 7:36 ` [Qemu-devel] [PATCH v4 3/3] arm: implement query-gic-capabilities Peter Xu
2016-03-16 10:30 ` Peter Maydell
2016-03-17 9:40 ` Peter Xu
2016-03-16 10:32 ` [Qemu-devel] [PATCH v4 0/3] ARM: add query-gic-capabilities SMP command Peter Maydell
2016-03-16 10:42 ` Andrea Bolognani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317090927.GG23495@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=abologna@redhat.com \
--cc=armbru@redhat.com \
--cc=drjones@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).