From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agUrY-0001Rz-S4 for qemu-devel@nongnu.org; Thu, 17 Mar 2016 06:09:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agUrV-0005qb-M2 for qemu-devel@nongnu.org; Thu, 17 Mar 2016 06:09:04 -0400 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:52603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agUrV-0005q2-Cb for qemu-devel@nongnu.org; Thu, 17 Mar 2016 06:09:01 -0400 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 17 Mar 2016 10:08:59 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 529844140035 for ; Thu, 17 Mar 2016 10:08:37 +0000 (GMT) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u2HA8tmU4784544 for ; Thu, 17 Mar 2016 10:08:55 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u2HA8sSB016690 for ; Thu, 17 Mar 2016 04:08:55 -0600 Date: Thu, 17 Mar 2016 11:08:52 +0100 From: Cornelia Huck Message-ID: <20160317110852.578e230e.cornelia.huck@de.ibm.com> In-Reply-To: <1458206430-21917-6-git-send-email-zxq_yx_007@163.com> References: <1458206430-21917-1-git-send-email-zxq_yx_007@163.com> <1458206430-21917-6-git-send-email-zxq_yx_007@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/6] hw/char: QOM'ify sclpconsole-lm.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: xiaoqiang zhao Cc: pbonzini@redhat.com, michael@walle.cc, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, agraf@suse.de On Thu, 17 Mar 2016 17:20:29 +0800 xiaoqiang zhao wrote: > Drop the DO_UPCAST macro > > Signed-off-by: xiaoqiang zhao > --- > hw/char/sclpconsole-lm.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/hw/char/sclpconsole-lm.c b/hw/char/sclpconsole-lm.c > index 7d4ff81..3dcc5a5 100644 > --- a/hw/char/sclpconsole-lm.c > +++ b/hw/char/sclpconsole-lm.c > @@ -44,6 +44,10 @@ typedef struct SCLPConsoleLM { > uint8_t buf[SIZE_CONSOLE_BUFFER]; > } SCLPConsoleLM; > > +#define TYPE_SCLP_LM_CONSOLE "sclplmconsole" > +#define SCLP_LM_CONSOLE(obj) \ > + OBJECT_CHECK(SCLPConsoleLM, (obj), TYPE_SCLP_LM_CONSOLE) I'd prefer SCLPLM over SCLP_LM (don't know, but the 'LM' looks a bit lonely ;)