From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60498)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1aga2F-0004eb-FT
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 11:40:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1aga2C-00042a-PI
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 11:40:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47007)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1aga2C-00042T-Jd
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 11:40:24 -0400
Date: Thu, 17 Mar 2016 17:40:20 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20160317173919-mutt-send-email-mst@redhat.com>
References: <1458053080-29170-1-git-send-email-mst@redhat.com>
	<87fuvpv2jv.fsf@blackfin.pond.sub.org>
	<20160317143531-mutt-send-email-mst@redhat.com>
	<56EAB17A.1000400@redhat.com>
	<20160317153528-mutt-send-email-mst@redhat.com>
	<56EAB768.2000406@redhat.com>
	<20160317160429-mutt-send-email-mst@redhat.com>
	<56EAC420.6090809@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56EAC420.6090809@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg
 without opt/
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Laszlo Ersek <lersek@redhat.com>, "Gabriel L. Somlo" <somlo@cmu.edu>, Gerd Hoffmann <kraxel@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

On Thu, Mar 17, 2016 at 03:50:08PM +0100, Paolo Bonzini wrote:
> 
> 
> On 17/03/2016 15:17, Michael S. Tsirkin wrote:
> > On Thu, Mar 17, 2016 at 02:55:52PM +0100, Paolo Bonzini wrote:
> >>
> >>
> >> On 17/03/2016 14:49, Michael S. Tsirkin wrote:
> >>>> On 17/03/2016 14:13, Michael S. Tsirkin wrote:
> >>>>>
> >>>>> QEMU command line:
> >>>>> 	A. -fw-cfg RFQDN/PATH prepends usr/. So users will not get conflicts
> >>>>> 	   with QEMU hardware
> >>>>
> >>>> Alternative: no need to prepend usr/, I think.
> >>>
> >>> I personally dislike telling user "do X". I don't see a reason not to be
> >>> friendly and do X. The rare case where users do not want X can be
> >>> easily enabled.
> >>
> >> I wouldn't include usr/ at all in the paths.  The RFQDN recommendation
> >> is enough to avoid clashes with etc/ and opt/.
> > 
> > Yes but then we need a blacklist.
> 
> Can't the blacklist be as simple as "org.qemu/*", plus some handling of
> legacy "etc/*"?
> 
> We'd need special handling of "etc/*" anyway because SeaBIOS is using it
> (Gerd's usecase) and you certainly don't want to use
> org.qemu/unsupported/etc/XYZ hacks for that.
> 
> Paolo

I would prefer a white-list, but I have an idea: look for "."
in the name. If not there, it's not an RFQDN.

-- 
MST