From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agfEj-0005CT-Oc for qemu-devel@nongnu.org; Thu, 17 Mar 2016 17:13:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agfEe-0004pN-Mw for qemu-devel@nongnu.org; Thu, 17 Mar 2016 17:13:41 -0400 Received: from e19.ny.us.ibm.com ([129.33.205.209]:34255) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agfEe-0004pH-IA for qemu-devel@nongnu.org; Thu, 17 Mar 2016 17:13:36 -0400 Received: from localhost by e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 17 Mar 2016 17:13:36 -0400 Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 243B16E8040 for ; Thu, 17 Mar 2016 17:00:24 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u2HLDXZM32833680 for ; Thu, 17 Mar 2016 21:13:33 GMT Received: from d01av04.pok.ibm.com (localhost [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u2HLDXuk030758 for ; Thu, 17 Mar 2016 17:13:33 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <1458141362-2608-1-git-send-email-stefanha@redhat.com> References: <1458141362-2608-1-git-send-email-stefanha@redhat.com> Message-ID: <20160317211302.32479.88456@loki> Date: Thu, 17 Mar 2016 16:13:02 -0500 Subject: Re: [Qemu-devel] [PATCH] qemu-ga: drop unused local err variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Quoting Stefan Hajnoczi (2016-03-16 10:16:02) > Commit 125b310e1d62e3a1dc1e7758563e598957ca7ae4 ("qemu-ga: move > channel/transport functionality into wrapper class") stopped using the > local err variable in channel_event_cb(). > = > This patch deletes the unused variable. > = > Signed-off-by: Stefan Hajnoczi Thanks, applied to qga tree: https://github.com/mdroth/qemu/commits/qga > --- > qga/main.c | 6 ------ > 1 file changed, 6 deletions(-) > = > diff --git a/qga/main.c b/qga/main.c > index 0a168e2..743c5c1 100644 > --- a/qga/main.c > +++ b/qga/main.c > @@ -618,13 +618,7 @@ static gboolean channel_event_cb(GIOCondition condit= ion, gpointer data) > GAState *s =3D data; > gchar buf[QGA_READ_COUNT_DEFAULT+1]; > gsize count; > - GError *err =3D NULL; > GIOStatus status =3D ga_channel_read(s->channel, buf, QGA_READ_COUNT= _DEFAULT, &count); > - if (err !=3D NULL) { > - g_warning("error reading channel: %s", err->message); > - g_error_free(err); > - return false; > - } > switch (status) { > case G_IO_STATUS_ERROR: > g_warning("error reading channel"); > -- = > 2.5.0 >=20