From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34363)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1agrwX-0003W6-Vb
	for qemu-devel@nongnu.org; Fri, 18 Mar 2016 06:47:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1agrwU-0005QU-P6
	for qemu-devel@nongnu.org; Fri, 18 Mar 2016 06:47:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42264)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1agrwU-0005QM-JT
	for qemu-devel@nongnu.org; Fri, 18 Mar 2016 06:47:42 -0400
Date: Fri, 18 Mar 2016 10:47:38 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160318104737.GD17895@redhat.com>
References: <20160317202556.GD8489@HEDWIG.INI.CMU.EDU>
	<87r3f8rsiv.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <87r3f8rsiv.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] commit 084a85e breaks build
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Gabriel L. Somlo" <somlo@cmu.edu>, qemu-devel@nongnu.org

On Fri, Mar 18, 2016 at 11:26:32AM +0100, Markus Armbruster wrote:
> You forgot to cc: Dan.  Fixed :)
> 
> I see similar diagnostics from F22's gcc.  Linking fails:
> 
> ../crypto/cipher.o: In function `qcrypto_cipher_new':
> /home/armbru/work/qemu/crypto/cipher-nettle.c:229: undefined reference to `cast5_set_key'
> /home/armbru/work/qemu/crypto/cipher-nettle.c:230: undefined reference to `cast5_set_key'
> /home/armbru/work/qemu/crypto/cipher-nettle.c:232: undefined reference to `cast5_set_key'

Ok, I have nettle 3.1.1 and you have 2.7.1 on Fedora 22. Looking at the NEWS
file it seems cast5_set_key was only added in the 3.x series, so I'll work on
a patch to make that use compatible with older nettle.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|