[Qemu-devel] commit 084a85e breaks build

qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed

* [Qemu-devel] commit 084a85e breaks build
@ 2016-03-17 20:25 Gabriel L. Somlo
  2016-03-18 10:22 ` Daniel P. Berrange
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Gabriel L. Somlo @ 2016-03-17 20:25 UTC (permalink / raw)
  To: qemu-devel

Hi Daniel,

I get the error below when I try to build QEMU, and bisect claims it
started with commit 084a85e (crypto: add support for the cast5-128
cipher algorithm).

Sorry if this is already a known issue. Let me know if there's
anything you'd like me to test.

My command line is:
~/KVM-OSX/SCRATCH/qemu/configure --prefix=/home/somlo/KVM-OSX/SCRATCH --audio-drv-list=pa --target-list=x86_64-softmmu,i386-softmmu,aarch64-softmmu,arm-softmmu; make install

Thanks,
--Gabriel

...
  CC    crypto/cipher.o
In file included from
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:0:
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c: In function
‘qcrypto_cipher_new’:
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:229:13: error:
implicit declaration of function ‘cast5_set_key’
[-Werror=implicit-function-declaration]
             cast5_set_key(ctx->ctx, nkey, key);
             ^
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:229:13: error:
nested extern declaration of ‘cast5_set_key’ [-Werror=nested-externs]
In file included from
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:0:
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c: In function
‘qcrypto_cipher_encrypt’:
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:344:21: error:
passing argument 3 of ‘xts_encrypt’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
                     ctx->alg_encrypt, ctx->alg_encrypt,
                     ^
In file included from
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:22:0,
                 from
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:
/home/somlo/KVM-OSX/SCRATCH/qemu/include/crypto/xts.h:76:6: note:
expected ‘void (*)(const void *, size_t,  uint8_t *, const uint8_t *)
{aka void (*)(const void *, long unsigned int,  unsigned char *, const
unsigned char *)}’ but argument is of type ‘void (*)(void *, unsigned
int,  uint8_t *, const uint8_t *) {aka void (*)(void *, unsigned int,
unsigned char *, const unsigned char *)}’
 void xts_encrypt(const void *datactx,
      ^
In file included from
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:0:
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:344:39: error:
passing argument 4 of ‘xts_encrypt’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
                     ctx->alg_encrypt, ctx->alg_encrypt,
                                       ^
In file included from
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:22:0,
                 from
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:
/home/somlo/KVM-OSX/SCRATCH/qemu/include/crypto/xts.h:76:6: note:
expected ‘void (*)(const void *, size_t,  uint8_t *, const uint8_t *)
{aka void (*)(const void *, long unsigned int,  unsigned char *, const
unsigned char *)}’ but argument is of type ‘void (*)(void *, unsigned
int,  uint8_t *, const uint8_t *) {aka void (*)(void *, unsigned int,
unsigned char *, const unsigned char *)}’
 void xts_encrypt(const void *datactx,
      ^
In file included from
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:0:
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c: In function
‘qcrypto_cipher_decrypt’:
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:389:21: error:
passing argument 3 of ‘xts_decrypt’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
                     ctx->alg_encrypt, ctx->alg_decrypt,
                     ^
In file included from
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:22:0,
                 from
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:
/home/somlo/KVM-OSX/SCRATCH/qemu/include/crypto/xts.h:54:6: note:
expected ‘void (*)(const void *, size_t,  uint8_t *, const uint8_t *)
{aka void (*)(const void *, long unsigned int,  unsigned char *, const
unsigned char *)}’ but argument is of type ‘void (*)(void *, unsigned
int,  uint8_t *, const uint8_t *) {aka void (*)(void *, unsigned int,
unsigned char *, const unsigned char *)}’
 void xts_decrypt(const void *datactx,
      ^
In file included from
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:0:
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:389:39: error:
passing argument 4 of ‘xts_decrypt’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
                     ctx->alg_encrypt, ctx->alg_decrypt,
                                       ^
In file included from
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:22:0,
                 from
/home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:
/home/somlo/KVM-OSX/SCRATCH/qemu/include/crypto/xts.h:54:6: note:
expected ‘void (*)(const void *, size_t,  uint8_t *, const uint8_t *)
{aka void (*)(const void *, long unsigned int,  unsigned char *, const
unsigned char *)}’ but argument is of type ‘void (*)(void *, unsigned
int,  uint8_t *, const uint8_t *) {aka void (*)(void *, unsigned int,
unsigned char *, const unsigned char *)}’
 void xts_decrypt(const void *datactx,
      ^
cc1: all warnings being treated as errors
/home/somlo/KVM-OSX/SCRATCH/qemu/rules.mak:57: recipe for target
'crypto/cipher.o' failed
make: *** [crypto/cipher.o] Error 1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] commit 084a85e breaks build
  2016-03-17 20:25 [Qemu-devel] commit 084a85e breaks build Gabriel L. Somlo
@ 2016-03-18 10:22 ` Daniel P. Berrange
  2016-03-18 10:26 ` Markus Armbruster
  2016-03-18 12:05 ` Daniel P. Berrange
  2 siblings, 0 replies; 5+ messages in thread
From: Daniel P. Berrange @ 2016-03-18 10:22 UTC (permalink / raw)
  To: Gabriel L. Somlo; +Cc: qemu-devel

On Thu, Mar 17, 2016 at 04:25:56PM -0400, Gabriel L. Somlo wrote:
> Hi Daniel,
> 
> I get the error below when I try to build QEMU, and bisect claims it
> started with commit 084a85e (crypto: add support for the cast5-128
> cipher algorithm).
> 
> Sorry if this is already a known issue. Let me know if there's
> anything you'd like me to test.

What version of nettle do you have installed ?


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] commit 084a85e breaks build
  2016-03-17 20:25 [Qemu-devel] commit 084a85e breaks build Gabriel L. Somlo
  2016-03-18 10:22 ` Daniel P. Berrange
@ 2016-03-18 10:26 ` Markus Armbruster
  2016-03-18 10:47   ` Daniel P. Berrange
  2016-03-18 12:05 ` Daniel P. Berrange
  2 siblings, 1 reply; 5+ messages in thread
From: Markus Armbruster @ 2016-03-18 10:26 UTC (permalink / raw)
  To: Gabriel L. Somlo; +Cc: qemu-devel

You forgot to cc: Dan.  Fixed :)

I see similar diagnostics from F22's gcc.  Linking fails:

../crypto/cipher.o: In function `qcrypto_cipher_new':
/home/armbru/work/qemu/crypto/cipher-nettle.c:229: undefined reference to `cast5_set_key'
/home/armbru/work/qemu/crypto/cipher-nettle.c:230: undefined reference to `cast5_set_key'
/home/armbru/work/qemu/crypto/cipher-nettle.c:232: undefined reference to `cast5_set_key'


"Gabriel L. Somlo" <somlo@cmu.edu> writes:

> Hi Daniel,
>
> I get the error below when I try to build QEMU, and bisect claims it
> started with commit 084a85e (crypto: add support for the cast5-128
> cipher algorithm).
>
> Sorry if this is already a known issue. Let me know if there's
> anything you'd like me to test.
>
> My command line is:
> ~/KVM-OSX/SCRATCH/qemu/configure --prefix=/home/somlo/KVM-OSX/SCRATCH --audio-drv-list=pa --target-list=x86_64-softmmu,i386-softmmu,aarch64-softmmu,arm-softmmu; make install
>
> Thanks,
> --Gabriel
>
> ...
>   CC    crypto/cipher.o
> In file included from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:0:
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c: In function
> ‘qcrypto_cipher_new’:
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:229:13: error:
> implicit declaration of function ‘cast5_set_key’
> [-Werror=implicit-function-declaration]
>              cast5_set_key(ctx->ctx, nkey, key);
>              ^
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:229:13: error:
> nested extern declaration of ‘cast5_set_key’ [-Werror=nested-externs]
> In file included from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:0:
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c: In function
> ‘qcrypto_cipher_encrypt’:
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:344:21: error:
> passing argument 3 of ‘xts_encrypt’ from incompatible pointer type
> [-Werror=incompatible-pointer-types]
>                      ctx->alg_encrypt, ctx->alg_encrypt,
>                      ^
> In file included from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:22:0,
>                  from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:
> /home/somlo/KVM-OSX/SCRATCH/qemu/include/crypto/xts.h:76:6: note:
> expected ‘void (*)(const void *, size_t,  uint8_t *, const uint8_t *)
> {aka void (*)(const void *, long unsigned int,  unsigned char *, const
> unsigned char *)}’ but argument is of type ‘void (*)(void *, unsigned
> int,  uint8_t *, const uint8_t *) {aka void (*)(void *, unsigned int,
> unsigned char *, const unsigned char *)}’
>  void xts_encrypt(const void *datactx,
>       ^
> In file included from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:0:
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:344:39: error:
> passing argument 4 of ‘xts_encrypt’ from incompatible pointer type
> [-Werror=incompatible-pointer-types]
>                      ctx->alg_encrypt, ctx->alg_encrypt,
>                                        ^
> In file included from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:22:0,
>                  from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:
> /home/somlo/KVM-OSX/SCRATCH/qemu/include/crypto/xts.h:76:6: note:
> expected ‘void (*)(const void *, size_t,  uint8_t *, const uint8_t *)
> {aka void (*)(const void *, long unsigned int,  unsigned char *, const
> unsigned char *)}’ but argument is of type ‘void (*)(void *, unsigned
> int,  uint8_t *, const uint8_t *) {aka void (*)(void *, unsigned int,
> unsigned char *, const unsigned char *)}’
>  void xts_encrypt(const void *datactx,
>       ^
> In file included from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:0:
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c: In function
> ‘qcrypto_cipher_decrypt’:
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:389:21: error:
> passing argument 3 of ‘xts_decrypt’ from incompatible pointer type
> [-Werror=incompatible-pointer-types]
>                      ctx->alg_encrypt, ctx->alg_decrypt,
>                      ^
> In file included from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:22:0,
>                  from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:
> /home/somlo/KVM-OSX/SCRATCH/qemu/include/crypto/xts.h:54:6: note:
> expected ‘void (*)(const void *, size_t,  uint8_t *, const uint8_t *)
> {aka void (*)(const void *, long unsigned int,  unsigned char *, const
> unsigned char *)}’ but argument is of type ‘void (*)(void *, unsigned
> int,  uint8_t *, const uint8_t *) {aka void (*)(void *, unsigned int,
> unsigned char *, const unsigned char *)}’
>  void xts_decrypt(const void *datactx,
>       ^
> In file included from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:0:
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:389:39: error:
> passing argument 4 of ‘xts_decrypt’ from incompatible pointer type
> [-Werror=incompatible-pointer-types]
>                      ctx->alg_encrypt, ctx->alg_decrypt,
>                                        ^
> In file included from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:22:0,
>                  from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:
> /home/somlo/KVM-OSX/SCRATCH/qemu/include/crypto/xts.h:54:6: note:
> expected ‘void (*)(const void *, size_t,  uint8_t *, const uint8_t *)
> {aka void (*)(const void *, long unsigned int,  unsigned char *, const
> unsigned char *)}’ but argument is of type ‘void (*)(void *, unsigned
> int,  uint8_t *, const uint8_t *) {aka void (*)(void *, unsigned int,
> unsigned char *, const unsigned char *)}’
>  void xts_decrypt(const void *datactx,
>       ^
> cc1: all warnings being treated as errors
> /home/somlo/KVM-OSX/SCRATCH/qemu/rules.mak:57: recipe for target
> 'crypto/cipher.o' failed
> make: *** [crypto/cipher.o] Error 1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] commit 084a85e breaks build
  2016-03-18 10:26 ` Markus Armbruster
@ 2016-03-18 10:47   ` Daniel P. Berrange
  0 siblings, 0 replies; 5+ messages in thread
From: Daniel P. Berrange @ 2016-03-18 10:47 UTC (permalink / raw)
  To: Markus Armbruster; +Cc: Gabriel L. Somlo, qemu-devel

On Fri, Mar 18, 2016 at 11:26:32AM +0100, Markus Armbruster wrote:
> You forgot to cc: Dan.  Fixed :)
> 
> I see similar diagnostics from F22's gcc.  Linking fails:
> 
> ../crypto/cipher.o: In function `qcrypto_cipher_new':
> /home/armbru/work/qemu/crypto/cipher-nettle.c:229: undefined reference to `cast5_set_key'
> /home/armbru/work/qemu/crypto/cipher-nettle.c:230: undefined reference to `cast5_set_key'
> /home/armbru/work/qemu/crypto/cipher-nettle.c:232: undefined reference to `cast5_set_key'

Ok, I have nettle 3.1.1 and you have 2.7.1 on Fedora 22. Looking at the NEWS
file it seems cast5_set_key was only added in the 3.x series, so I'll work on
a patch to make that use compatible with older nettle.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] commit 084a85e breaks build
  2016-03-17 20:25 [Qemu-devel] commit 084a85e breaks build Gabriel L. Somlo
  2016-03-18 10:22 ` Daniel P. Berrange
  2016-03-18 10:26 ` Markus Armbruster
@ 2016-03-18 12:05 ` Daniel P. Berrange
  2 siblings, 0 replies; 5+ messages in thread
From: Daniel P. Berrange @ 2016-03-18 12:05 UTC (permalink / raw)
  To: Gabriel L. Somlo; +Cc: qemu-devel, armbru

On Thu, Mar 17, 2016 at 04:25:56PM -0400, Gabriel L. Somlo wrote:
> Hi Daniel,
> 
> I get the error below when I try to build QEMU, and bisect claims it
> started with commit 084a85e (crypto: add support for the cast5-128
> cipher algorithm).
> 
> Sorry if this is already a known issue. Let me know if there's
> anything you'd like me to test.

BTW, as an immediate workaround to let you carry on work with, you can
pass the --disable-nettle flag to configure.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-03-18 12:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-17 20:25 [Qemu-devel] commit 084a85e breaks build Gabriel L. Somlo
2016-03-18 10:22 ` Daniel P. Berrange
2016-03-18 10:26 ` Markus Armbruster
2016-03-18 10:47   ` Daniel P. Berrange
2016-03-18 12:05 ` Daniel P. Berrange

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).