From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57540)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from
	<SRS0=2jJ8=PQ=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1ahdTX-0003Og-Ra
	for qemu-devel@nongnu.org; Sun, 20 Mar 2016 09:33:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from
	<SRS0=2jJ8=PQ=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1ahdTS-0004PW-TZ
	for qemu-devel@nongnu.org; Sun, 20 Mar 2016 09:32:59 -0400
Received: from sonata.ens-lyon.org ([140.77.166.138]:43378)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from
	<SRS0=2jJ8=PQ=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1ahdTS-0004OQ-Ml
	for qemu-devel@nongnu.org; Sun, 20 Mar 2016 09:32:54 -0400
Date: Sun, 20 Mar 2016 14:32:52 +0100
From: Samuel Thibault <samuel.thibault@gnu.org>
Message-ID: <20160320133252.GZ3635@var.home>
References: <1458473954-18583-1-git-send-email-samuel.thibault@ens-lyon.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1458473954-18583-1-git-send-email-samuel.thibault@ens-lyon.org>
Subject: Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: thuth@redhat.com, jan.kiszka@siemens.com, jasowang@redhat.com, armbru@redhat.com

Samuel Thibault, on Sun 20 Mar 2016 12:39:14 +0100, wrote:
>  void icmp6_init(Slirp *slirp)
>  {
> +    if (in6_zero(&slirp->vprefix_addr6)) {
> +        /* IPv6 is disabled */
> +        return;
> +    }
> +

(Note: vprefix_addr6 is not actually initialized yet at that point, which
poses problem, I'll fix that later, I was more asking for reviewing the
principle of the patch itself, the option value, etc.).

Samuel