From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50975)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1ahxmw-0005IU-Oe
	for qemu-devel@nongnu.org; Mon, 21 Mar 2016 07:14:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1ahxms-0002Ra-Oj
	for qemu-devel@nongnu.org; Mon, 21 Mar 2016 07:14:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42506)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1ahxms-0002RW-Jq
	for qemu-devel@nongnu.org; Mon, 21 Mar 2016 07:14:18 -0400
Date: Mon, 21 Mar 2016 11:14:16 +0000
From: "Richard W.M. Jones" <rjones@redhat.com>
Message-ID: <20160321111416.GC19398@redhat.com>
References: <1454065944-15887-1-git-send-email-markmb@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1454065944-15887-1-git-send-email-markmb@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg
 DMA version
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marc =?iso-8859-1?Q?Mar=ED?= <markmb@redhat.com>
Cc: Marc =?iso-8859-1?Q?Mar=ED?= <marc.mari.barcelo@gmail.com>, "Gabriel L. Somlo" <somlo@cmu.edu>, qemu-devel@nongnu.org, Kevin O'Connor <kevin@koconnor.net>, Gerd Hoffmann <kraxel@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Laszlo <lersek@redhat.com>

My notes on this patch:

* It applies and compiles fine with current qemu on Linux/x86_64 host.
  However after building I had to do:

  cp pc-bios/optionrom/linuxboot_dma.bin pc-bios/

  I wasn't sure if that was supposed to be done automatically.

* It reduces libguestfs appliance boot time by about =BD second
  (2.00 s -> 1.53 s), so that's excellent.

* Overhead of BIOS-to-kernel drops from nearly 50% to under 20% of the
  total libguestfs appliance boot time.  SeaBIOS is still using 0.27
  seconds, of which at least 0.12 seconds is PCI bus scanning.

Anyway, all in all, a good change!

Rich.

--=20
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rj=
ones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW