From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time
Date: Mon, 21 Mar 2016 18:39:57 +0100 [thread overview]
Message-ID: <20160321173957.GC4985@noname.redhat.com> (raw)
In-Reply-To: <87shzj68n2.fsf@blackfin.pond.sub.org>
Am 21.03.2016 um 18:30 hat Markus Armbruster geschrieben:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
> > On 21/03/2016 17:15, Markus Armbruster wrote:
> >> * Explicitly with x-blockdev-del
> >>
> >> Fails unless no other reference exists. Where is the legacy_dinfo
> >> released?
> >
> > Can a -drive block device be deleted with x-blockdev-del even?!?
>
> When I wrote my review, I forgot that I expect x-blockdev-del to accept
> only backends created with blockdev-add. With that, my question is
> indeed moot.
>
> However, I've now tested my expectation, and it turned out to be wrong.
> I'm inclined to call that a bug.
Yes.
> > Shall I add a check to x-blockdev-del that gives an error if the
> > BlockBackend has a DriveInfo attached?
>
> Yes, please. But do double-check with Kevin & Max, who might have
> different ideas on blockdev-add/del than I do.
I'm pretty sure that I said that failing on -drive/drive_add created
BlockBackends was a requirement for x-blockdev-del. Apparently I failed
to catch the bug in the review then.
So go ahead and let's fix it now.
Kevin
next prev parent reply other threads:[~2016-03-21 17:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 14:39 [Qemu-devel] [PATCH 0/3] Early release of -drive QemuOpts Paolo Bonzini
2016-02-22 14:39 ` [Qemu-devel] [PATCH 1/3] block: detach devices from DriveInfo at unrealize time Paolo Bonzini
2016-03-21 15:13 ` Markus Armbruster
2016-03-21 15:31 ` Paolo Bonzini
2016-03-21 17:19 ` Markus Armbruster
2016-03-21 17:30 ` Paolo Bonzini
2016-03-23 8:35 ` Markus Armbruster
2016-03-23 9:35 ` Paolo Bonzini
2016-03-22 22:15 ` Paolo Bonzini
2016-02-22 14:39 ` [Qemu-devel] [PATCH 2/3] block: keep BlockBackend alive until device finalize time Paolo Bonzini
2016-03-21 15:22 ` Markus Armbruster
2016-03-21 15:37 ` Paolo Bonzini
2016-02-22 14:39 ` [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time Paolo Bonzini
2016-03-21 16:15 ` Markus Armbruster
2016-03-21 16:21 ` Paolo Bonzini
2016-03-21 17:30 ` Markus Armbruster
2016-03-21 17:34 ` Paolo Bonzini
2016-03-21 18:14 ` Markus Armbruster
2016-03-22 8:19 ` Kevin Wolf
2016-03-22 10:25 ` Markus Armbruster
2016-03-22 22:07 ` Paolo Bonzini
2016-03-23 9:18 ` Markus Armbruster
2016-03-23 9:40 ` Paolo Bonzini
2016-03-23 12:13 ` Markus Armbruster
2016-03-21 17:39 ` Kevin Wolf [this message]
2016-03-21 18:02 ` Markus Armbruster
2016-03-22 22:10 ` Paolo Bonzini
2016-03-23 8:37 ` Markus Armbruster
2016-03-09 12:20 ` [Qemu-devel] [PATCH 0/3] Early release of -drive QemuOpts Paolo Bonzini
2016-03-09 12:30 ` Kevin Wolf
2016-03-09 12:53 ` Markus Armbruster
2016-03-17 17:00 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160321173957.GC4985@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).