From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiAqN-0007DC-4f for qemu-devel@nongnu.org; Mon, 21 Mar 2016 21:10:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiAqJ-0001p8-SK for qemu-devel@nongnu.org; Mon, 21 Mar 2016 21:10:47 -0400 Date: Tue, 22 Mar 2016 12:11:51 +1100 From: David Gibson Message-ID: <20160322011151.GU23586@voom.redhat.com> References: <1458546426-26222-1-git-send-email-aik@ozlabs.ru> <1458546426-26222-6-git-send-email-aik@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="twKjCw1/F6C/WBH6" Content-Disposition: inline In-Reply-To: <1458546426-26222-6-git-send-email-aik@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH qemu v14 05/18] spapr_iommu: Introduce "enabled" state for TCE table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Alex Williamson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org --twKjCw1/F6C/WBH6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 21, 2016 at 06:46:53PM +1100, Alexey Kardashevskiy wrote: > Currently TCE tables are created once at start and their sizes never > change. We are going to change that by introducing a Dynamic DMA windows > support where DMA configuration may change during the guest execution. >=20 > This changes spapr_tce_new_table() to create an empty zero-size IOMMU > memory region (IOMMU MR). Only LIOBN is assigned by the time of creation. > It still will be called once at the owner object (VIO or PHB) creation. >=20 > This introduces an "enabled" state for TCE table objects with two > helper functions - spapr_tce_table_enable()/spapr_tce_table_disable(). > - spapr_tce_table_enable() receives TCE table parameters, allocates > a guest view of the TCE table (in the user space or KVM) and > sets the correct size on the IOMMU MR. > - spapr_tce_table_disable() disposes the table and resets the IOMMU MR > size. >=20 > This changes the PHB reset handler to do the default DMA initialization > instead of spapr_phb_realize(). This does not make differenct now but > later with more than just one DMA window, we will have to remove them all > and create the default one on a system reset. >=20 > No visible change in behaviour is expected except the actual table > will be reallocated every reset. We might optimize this later. >=20 > The other way to implement this would be dynamically create/remove > the TCE table QOM objects but this would make migration impossible > as the migration code expects all QOM objects to exist at the receiver > so we have to have TCE table objects created when migration begins. >=20 > spapr_tce_table_do_enable() is separated from from spapr_tce_table_enable= () > as later it will be called at the sPAPRTCETable post-migration stage when > it already has all the properties set after the migration; the same is > done for spapr_tce_table_disable(). >=20 > Signed-off-by: Alexey Kardashevskiy > Reviewed-by: David Gibson R-b stands, but I noticed one nit: > --- > Changes: > v14: > * added spapr_tce_table_do_disable(), will make difference in following > patch with fully dynamic table migration > --- > hw/ppc/spapr_iommu.c | 86 ++++++++++++++++++++++++++++++++++++--------= ------ > hw/ppc/spapr_pci.c | 13 ++++++-- > hw/ppc/spapr_vio.c | 8 ++--- > include/hw/ppc/spapr.h | 10 +++--- > 4 files changed, 81 insertions(+), 36 deletions(-) >=20 > diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c > index 8132f64..9bcd3f6 100644 > --- a/hw/ppc/spapr_iommu.c > +++ b/hw/ppc/spapr_iommu.c > @@ -17,6 +17,7 @@ > * License along with this library; if not, see . > */ > #include "qemu/osdep.h" > +#include "qemu/error-report.h" > #include "hw/hw.h" > #include "sysemu/kvm.h" > #include "hw/qdev.h" > @@ -174,15 +175,9 @@ static int spapr_tce_table_realize(DeviceState *dev) > sPAPRTCETable *tcet =3D SPAPR_TCE_TABLE(dev); > =20 > tcet->fd =3D -1; > - tcet->table =3D spapr_tce_alloc_table(tcet->liobn, > - tcet->page_shift, > - tcet->nb_table, > - &tcet->fd, > - tcet->need_vfio); > - > + tcet->need_vfio =3D false; > memory_region_init_iommu(&tcet->iommu, OBJECT(dev), &spapr_iommu_ops, > - "iommu-spapr", > - (uint64_t)tcet->nb_table << tcet->page_shif= t); > + "iommu-spapr", 0); > =20 > QLIST_INSERT_HEAD(&spapr_tce_tables, tcet, list); > =20 > @@ -224,14 +219,10 @@ void spapr_tce_set_need_vfio(sPAPRTCETable *tcet, b= ool need_vfio) > tcet->table =3D newtable; > } > =20 > -sPAPRTCETable *spapr_tce_new_table(DeviceState *owner, uint32_t liobn, > - uint64_t bus_offset, > - uint32_t page_shift, > - uint32_t nb_table, > - bool need_vfio) > +sPAPRTCETable *spapr_tce_new_table(DeviceState *owner, uint32_t liobn) > { > sPAPRTCETable *tcet; > - char tmp[64]; > + char tmp[32]; > =20 > if (spapr_tce_find_by_liobn(liobn)) { > fprintf(stderr, "Attempted to create TCE table with duplicate" > @@ -239,16 +230,8 @@ sPAPRTCETable *spapr_tce_new_table(DeviceState *owne= r, uint32_t liobn, > return NULL; > } > =20 > - if (!nb_table) { > - return NULL; > - } > - > tcet =3D SPAPR_TCE_TABLE(object_new(TYPE_SPAPR_TCE_TABLE)); > tcet->liobn =3D liobn; > - tcet->bus_offset =3D bus_offset; > - tcet->page_shift =3D page_shift; > - tcet->nb_table =3D nb_table; > - tcet->need_vfio =3D need_vfio; > =20 > snprintf(tmp, sizeof(tmp), "tce-table-%x", liobn); > object_property_add_child(OBJECT(owner), tmp, OBJECT(tcet), NULL); > @@ -258,14 +241,69 @@ sPAPRTCETable *spapr_tce_new_table(DeviceState *own= er, uint32_t liobn, > return tcet; > } > =20 > +static void spapr_tce_table_do_enable(sPAPRTCETable *tcet) > +{ > + if (!tcet->nb_table) { > + return; > + } > + > + tcet->table =3D spapr_tce_alloc_table(tcet->liobn, > + tcet->page_shift, > + tcet->nb_table, > + &tcet->fd, > + tcet->need_vfio); > + > + memory_region_set_size(&tcet->iommu, > + (uint64_t)tcet->nb_table << tcet->page_shift); > + > + tcet->enabled =3D true; > +} > + > +void spapr_tce_table_enable(sPAPRTCETable *tcet, > + uint32_t page_shift, uint64_t bus_offset, > + uint32_t nb_table) > +{ > + if (tcet->enabled) { > + error_report("Warning: trying to enable already enabled TCE tabl= e"); > + return; > + } > + > + tcet->bus_offset =3D bus_offset; > + tcet->page_shift =3D page_shift; > + tcet->nb_table =3D nb_table; > + > + spapr_tce_table_do_enable(tcet); > +} > + > +static void spapr_tce_table_do_disable(sPAPRTCETable *tcet) > +{ > + memory_region_set_size(&tcet->iommu, 0); > + > + spapr_tce_free_table(tcet->table, tcet->fd, tcet->nb_table); > + tcet->fd =3D -1; > + tcet->table =3D NULL; > + tcet->enabled =3D false; > + tcet->bus_offset =3D 0; > + tcet->page_shift =3D 0; > + tcet->nb_table =3D 0; > +} > + > +static void spapr_tce_table_disable(sPAPRTCETable *tcet) > +{ > + if (!tcet->enabled) { > + error_report("Warning: trying to disable already disabled TCE ta= ble"); > + return; > + } > + spapr_tce_table_do_disable(tcet); > +} > + > static void spapr_tce_table_unrealize(DeviceState *dev, Error **errp) > { > sPAPRTCETable *tcet =3D SPAPR_TCE_TABLE(dev); > =20 > QLIST_REMOVE(tcet, list); > =20 > - spapr_tce_free_table(tcet->table, tcet->fd, tcet->nb_table); > - tcet->fd =3D -1; > + spapr_tce_table_disable(tcet); > } > =20 > MemoryRegion *spapr_tce_get_iommu(sPAPRTCETable *tcet) > diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c > index 18332bf..df5f7b9 100644 > --- a/hw/ppc/spapr_pci.c > +++ b/hw/ppc/spapr_pci.c > @@ -818,14 +818,15 @@ static void spapr_phb_dma_window_enable(sPAPRPHBSta= te *sphb, > return; > } > =20 > - tcet =3D spapr_tce_new_table(DEVICE(sphb), liobn, window_addr, > - page_shift, nb_table, false); > + tcet =3D spapr_tce_find_by_liobn(liobn); > if (!tcet) { > error_setg(errp, "Unable to create TCE table liobn %x for %s", > liobn, sphb->dtbusname); > return; > } > =20 > + spapr_tce_table_enable(tcet, page_shift, window_addr, nb_table); > + > memory_region_add_subregion(&sphb->iommu_root, tcet->bus_offset, > spapr_tce_get_iommu(tcet)); > } > @@ -1335,6 +1336,7 @@ static void spapr_phb_realize(DeviceState *dev, Err= or **errp) > PCIBus *bus; > uint64_t msi_window_size =3D 4096; > Error *local_err =3D NULL; > + sPAPRTCETable *tcet; > =20 > if (sphb->index !=3D (uint32_t)-1) { > hwaddr windows_base; > @@ -1486,6 +1488,13 @@ static void spapr_phb_realize(DeviceState *dev, Er= ror **errp) > } > } > =20 > + /* DMA setup */ > + tcet =3D spapr_tce_new_table(DEVICE(sphb), sphb->dma_liobn); > + if (!tcet) { > + error_report("No default TCE table for %s", sphb->dtbusname); > + return; You have an errp in this function so you should error_setg(), rather than just error_report(). > + } > + > /* Register default 32bit DMA window */ > spapr_phb_dma_window_enable(sphb, sphb->dma_liobn, SPAPR_TCE_PAGE_SH= IFT, > sphb->dma_win_addr, sphb->dma_win_size, > diff --git a/hw/ppc/spapr_vio.c b/hw/ppc/spapr_vio.c > index 0f61a55..7f57290 100644 > --- a/hw/ppc/spapr_vio.c > +++ b/hw/ppc/spapr_vio.c > @@ -481,11 +481,9 @@ static void spapr_vio_busdev_realize(DeviceState *qd= ev, Error **errp) > memory_region_add_subregion_overlap(&dev->mrroot, 0, &dev->mrbyp= ass, 1); > address_space_init(&dev->as, &dev->mrroot, qdev->id); > =20 > - dev->tcet =3D spapr_tce_new_table(qdev, liobn, > - 0, > - SPAPR_TCE_PAGE_SHIFT, > - pc->rtce_window_size >> > - SPAPR_TCE_PAGE_SHIFT, false); > + dev->tcet =3D spapr_tce_new_table(qdev, liobn); > + spapr_tce_table_enable(dev->tcet, SPAPR_TCE_PAGE_SHIFT, 0, > + pc->rtce_window_size >> SPAPR_TCE_PAGE_SH= IFT); > dev->tcet->vdev =3D dev; > memory_region_add_subregion_overlap(&dev->mrroot, 0, > spapr_tce_get_iommu(dev->tce= t), 2); > diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h > index 098d85d..75b0b55 100644 > --- a/include/hw/ppc/spapr.h > +++ b/include/hw/ppc/spapr.h > @@ -539,6 +539,7 @@ typedef struct sPAPRTCETable sPAPRTCETable; > =20 > struct sPAPRTCETable { > DeviceState parent; > + bool enabled; > uint32_t liobn; > uint32_t nb_table; > uint64_t bus_offset; > @@ -566,11 +567,10 @@ void spapr_events_fdt_skel(void *fdt, uint32_t epow= _irq); > int spapr_h_cas_compose_response(sPAPRMachineState *sm, > target_ulong addr, target_ulong size, > bool cpu_update, bool memory_update); > -sPAPRTCETable *spapr_tce_new_table(DeviceState *owner, uint32_t liobn, > - uint64_t bus_offset, > - uint32_t page_shift, > - uint32_t nb_table, > - bool need_vfio); > +sPAPRTCETable *spapr_tce_new_table(DeviceState *owner, uint32_t liobn); > +void spapr_tce_table_enable(sPAPRTCETable *tcet, > + uint32_t page_shift, uint64_t bus_offset, > + uint32_t nb_table); > void spapr_tce_set_need_vfio(sPAPRTCETable *tcet, bool need_vfio); > =20 > MemoryRegion *spapr_tce_get_iommu(sPAPRTCETable *tcet); --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --twKjCw1/F6C/WBH6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW8JvWAAoJEGw4ysog2bOSTSQQAOKMDwL+9YFdhUYPMYZTal3D rouwDe6KZMnRI9xfiugwEYA8+bIo+PoomBTEFO6XjD6g5poeE4sJyHZRU1FOKVuf y7lg6KJG88F7oUX3ZBfDpeoARx8i3vvQKbwOhZlVS7/BonV5wHV6T2sadxAXt9AQ u+p4mWc+7vD3sKQ4zqPUnjJ0oxLbqDfFUsPyZBJF7qBMnTFJ2r9FiRCwF+z+4grj 9E0aWbKZxdH8FNKxR1pOXT+XsEBl1VVXPFQ2QBQpiCNtwQyuuX4sUGYM0uIx3i6C +x/A1SJgk61o+dmEKKKmjTh67k1pl6ve6i4iGq9pv1BdIaia15p1DOKZcIsQ7Ctp 2SFKf09WtR9rQYXo5NM47xEnw+MLLyZ7XO0oemFCj00RUHJF13dO27P4tHIEeqOL +G+qXSTfJ8k/1QFQ0RAp9dXmmD2axEBwXis/mnkQ22djtkSdlyB10CW5HSidRBvs OAT1W2SjImtaNymDojaFkmnDngwVYN8ru9cg2EugaHsUYZaUecTz0Y98jt2w9Y// IRh9Fv7z2diDgBgVhPpk4pjwCsOI0c9p2pbArtWOyKDhU1p3P3sDwnux474wZcd3 mBv8OQT1GmlfKw3W+LKBr455VIdGVJu78PJie2QqLrHiLyzqoXhGqErAak1GQ41+ OZa/2sV8KbF8wnVUHeFy =P4IG -----END PGP SIGNATURE----- --twKjCw1/F6C/WBH6--