From: Peter Xu <peterx@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] block/qapi: make two printf() formats literal
Date: Tue, 22 Mar 2016 10:04:18 +0800 [thread overview]
Message-ID: <20160322020418.GC4468@pxdev.xzpeter.org> (raw)
In-Reply-To: <56F06448.50308@redhat.com>
On Mon, Mar 21, 2016 at 03:14:48PM -0600, Eric Blake wrote:
> On 03/09/2016 06:46 PM, Peter Xu wrote:
> >
> > Is this a grammar btw?
>
> Yes, C has an ugly grammar, because [] is just syntactic sugar for
> deferencing pointer addition with nicer operator precedence. Quoting
> C99 6.5.2.1:
>
> "The definition of the subscript operator [] is that E1[E2] is identical
> to (*((E1)+(E2))). Because of the conversion rules that apply to the
> binary + operator, if E1 is an array object (equivalently, a pointer to
> the initial element of an array object) and E2 is an integer, E1[E2]
> designates the E2-th element of E1 (counting from zero)."
>
> And a string literal is just a fancy way of writing the address of an
> array of characters (where the address is chosen by the compiler).
>
> Thus, it IS valid to dereference the addition of an integer offset with
> the address implied by a string literal in order to obtain a character
> within the string. And since the [] operator is commutative (even
> though no one in their right mind commutes the operands), you can also
> write the even-uglier:
>
> composite["\n "]
>
> But now we've gone far astray from the original patch review :)
Interesting thing to know. Thanks. :)
-- peterx
next prev parent reply other threads:[~2016-03-22 2:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 5:56 [Qemu-devel] [PATCH 0/2] block/qapi: trivial fixes Peter Xu
2016-03-09 5:56 ` [Qemu-devel] [PATCH 1/2] block/qapi: make two printf() formats literal Peter Xu
2016-03-09 22:14 ` Eric Blake
2016-03-10 1:46 ` Peter Xu
2016-03-21 21:14 ` Eric Blake
2016-03-22 2:04 ` Peter Xu [this message]
2016-03-22 15:47 ` Markus Armbruster
2016-03-09 5:56 ` [Qemu-devel] [PATCH 2/2] block/qapi: fix unbounded stack for dump_qdict Peter Xu
2016-03-09 22:16 ` Eric Blake
2016-03-22 15:48 ` Markus Armbruster
2016-03-22 15:50 ` [Qemu-devel] [PATCH 0/2] block/qapi: trivial fixes Markus Armbruster
2016-03-22 16:27 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160322020418.GC4468@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).