From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai9P8-00025D-OQ for qemu-devel@nongnu.org; Mon, 21 Mar 2016 19:38:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai9P5-0001CE-Fs for qemu-devel@nongnu.org; Mon, 21 Mar 2016 19:38:34 -0400 Date: Tue, 22 Mar 2016 10:39:28 +1100 From: David Gibson Message-ID: <20160322103928.3a148dbd@voom.fritz.box> In-Reply-To: <20160321115323.070494b7@nial.brq.redhat.com> References: <1458048248-4605-1-git-send-email-imammedo@redhat.com> <1458048248-4605-2-git-send-email-imammedo@redhat.com> <20160318192628.GK2856@thinpad.lan.raisama.net> <20160321115323.070494b7@nial.brq.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/0N0_pemNRKLdLmpZgkYsRQW"; protocol="application/pgp-signature" Subject: Re: [Qemu-devel] [PATCH v3 1/2] QMP: add query-hotpluggable-cpus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: mjrosato@linux.vnet.ibm.com, pkrempa@redhat.com, Eduardo Habkost , qemu-devel@nongnu.org, agraf@suse.de, armbru@redhat.com, borntraeger@de.ibm.com, qemu-ppc@nongnu.org, bharata@linux.vnet.ibm.com, cornelia.huck@de.ibm.com, afaerber@suse.de --Sig_/0N0_pemNRKLdLmpZgkYsRQW Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 21 Mar 2016 11:53:23 +0100 Igor Mammedov wrote: > On Fri, 18 Mar 2016 16:26:28 -0300 > Eduardo Habkost wrote: >=20 > > On Tue, Mar 15, 2016 at 02:24:07PM +0100, Igor Mammedov wrote: > > [...] =20 > > > diff --git a/stubs/qmp_query_hotpluggable_cpus.c b/stubs/qmp_query_ho= tpluggable_cpus.c > > > new file mode 100644 > > > index 0000000..21a75a3 > > > --- /dev/null > > > +++ b/stubs/qmp_query_hotpluggable_cpus.c > > > @@ -0,0 +1,9 @@ > > > +#include "qemu/osdep.h" > > > +#include "qapi/qmp/qerror.h" > > > +#include "qmp-commands.h" > > > + > > > +HotpluggableCPUList *qmp_query_hotpluggable_cpus(Error **errp) > > > +{ > > > + error_setg(errp, QERR_FEATURE_DISABLED, "query-hotpluggable-cpus= "); > > > + return NULL; > > > +} =20 > >=20 > > Sorry if this was discussed in previous threads that I haven't > > read, but: isn't this supposed to be a MachineClass method? I > > remember David saying once that we have the habit of assuming > > that a single QEMU binary can run only one family of machines > > that are very similar (like x86), but that's not always true. =20 > Stub approach works for current qemu with one target per binary > but it won't for multi-target binary. This approach won't work even now. We have draft implementations of the hook for spapr, but those are absolutely wrong for mac99 or the many other ppc machine classes. > I've been trying to not clutter MachineClass with hooks > that not must have right now but I don't have a strong opinion > on this so if MachineClass method is preferred way, > I can rewrite it this patch to use it on respin. >=20 >=20 --=20 David Gibson Senior Software Engineer, Virtualization, Red Hat --Sig_/0N0_pemNRKLdLmpZgkYsRQW Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW8IYwAAoJEGw4ysog2bOSM3kQAMrlUaieXrVolaXYD/29MeCz +4UrBwofEB4ClEpTlL27Q/6R27azzV748DA5a/CYOnuEZRkoaYoMWUamIu66tHUd iAfSbBXTdZ1RyKkLMY5AttSjzs9PF9cX8nmz+tWBi5o+h4Rf974NZAFGhxmHUcx2 DCsTVKQ9zJ86omkiTppnBP6ixltXcbRafzRNQ4c0y3+uQz9Njjgu7SMtuJ2PhCAB mfXQ93T6Oxc/6z9OGgO4M1ZdcgO60pjp1P4L9znoZtrbh4njbUr75FcBXz/mYdUO u9CRDCdjVm9UvxUix9xtmOrpYPDBMNWQkVveU+gDPvTGY2+Rndclq89Pg02qnfho Tdhf9mTBHrjUPpi6udlW/IKbw1GPo2sKiHUS72qyrt8+XJmb7rhov3NCU29n0XNT D7bvYGd4kiBC1SnmXZWbIFDi8d58VBmJd5i49vyiTXpjbwWJK2RXPNHGyOd1noce QxkKj36gZGBLNC5COnI0THF2kvRYmN81vQYpOxyIR2DOSnnrgKL2463ElLDlWjDa KnIm6Lo/O18YP6ZSK87IlGIar8uEtZ7af0pe8S52Pi3/4EGjit+ZST3uTUOOSO0D o76vV14t6vZw/54IrTVBjTKOE1/d8LrAytn5qn6aGuyFyLQqyO+1hpCJTGa91csH LbJiMQ2MNZj3FRM08P+n =r071 -----END PGP SIGNATURE----- --Sig_/0N0_pemNRKLdLmpZgkYsRQW--