From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38064)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1aiJlI-0002Kx-FO
	for qemu-devel@nongnu.org; Tue, 22 Mar 2016 06:42:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1aiJlH-0000HE-DA
	for qemu-devel@nongnu.org; Tue, 22 Mar 2016 06:42:08 -0400
Date: Tue, 22 Mar 2016 10:42:00 +0000
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20160322104200.GD29248@stefanha-x1.localdomain>
References: <1458416563-4381-1-git-send-email-stefanha@redhat.com>
	<CACyqxevrM1WPdGRn0s=-LDfj_yOfwpewH6UYg+jFpBYzChoF5w@mail.gmail.com>
	<20160321095655.GA15832@stefanha-x1.localdomain>
	<878u1blls5.fsf@earth.catern.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="7DO5AaGCk89r4vaK"
Content-Disposition: inline
In-Reply-To: <878u1blls5.fsf@earth.catern.com>
Subject: Re: [Qemu-devel] [PATCH] vpc: use current_size field for XenServer
	VHD images
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Spencer Baugh <sbaugh@catern.com>
Cc: Grant Wu <grantwwu@gmail.com>, Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, qemu-block@nongnu.org


--7DO5AaGCk89r4vaK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 21, 2016 at 02:37:46PM -0400, Spencer Baugh wrote:
> Stefan Hajnoczi <stefanha@redhat.com> writes:
> > What output did you get from "qemu-img info /dev/dm-1"?
>=20
> After the patching:
>=20
> root@storage-4:~# hexdump -C -n 512 /dev/vgstorage/tartanfsbackup
> 00000000  63 6f 6e 65 63 74 69 78  00 00 00 02 00 01 00 00 |conectix.....=
=2E..|
> 00000010  00 00 00 00 00 00 02 00  14 10 4b 1f 71 65 6d 32 |..........K.q=
em2|
> 00000020  00 01 00 03 00 00 00 00  00 00 01 c4 4f 40 00 00 |............O=
@..|
> 00000030  00 00 01 f4 00 00 00 00  ff ff 10 ff 00 00 00 03 |.............=
=2E..|
> 00000040  ff ff ed 81 6d 0d 68 bd  9c fd 4d 65 a3 17 c7 6c |....m.h...Me.=
=2E.l|
> 00000050  06 a6 aa bf 00 00 00 00  00 00 00 00 00 00 00 00 |.............=
=2E..|
> 00000060  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00 |.............=
=2E..|
> *
> 00000200
> root@storage-4:~# qemu-img info /dev/vgstorage/tartanfsbackup
> block-vpc: The header checksum of '/dev/vgstorage/tartanfsbackup' is inco=
rrect.

This is a warning message that does not cause opening the file to fail.
It makes sense since the header was modified without setting the new
checksum value.

> qemu-img: Could not open '/dev/vgstorage/tartanfsbackup': Could not open =
'/dev/vgstorage/tartanfsbackup': Invalid argument

Please also post the output of "hexdump -C -n 512 -s 512
/dev/vgstorage/tartanfsbackup".  This is another header structure and it
gets parsed while opening the file.

Thanks,
Stefan

--7DO5AaGCk89r4vaK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJW8SF4AAoJEJykq7OBq3PIEecH/3PBsX6ReTUDXyW+Hb2kPcgk
RCNCcTOKUgOPYo7P0fVwlkaPmEm1o/E2cB+bCtvJb8IeBBZ/y/YhN3btHtO1j7hX
l/IPjzTzgFnh0wwJfe0toc87s/j8bYXNLHHQw5DxjmdEuRXSrUuVC6zBMWspLEXf
P9sDILco5sNDcNHj/32hZJAVc3ug1H/JGByGJ1yWV9whLM7IcHuGrk7DVv8TIXa0
jDxOy4nIHEg2HBZqplq/ZRJV/Eh0dd+fpu5E1gPbjN3YUGaZ2Q64jDqcxpbjMV3W
CL/OU74i2scWlHIH/o7cq4OmBWtlgB71PfFw3rORcIvBI3vkiZqtF+gcXbIlX68=
=+WE/
-----END PGP SIGNATURE-----

--7DO5AaGCk89r4vaK--