qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 0/5] trace: Add events for vCPU memory accesses
Date: Tue, 22 Mar 2016 12:55:02 +0000	[thread overview]
Message-ID: <20160322125502.GH29248@stefanha-x1.localdomain> (raw)
In-Reply-To: <CAFEAcA-5WdrUPKduLjFvu82uiTzUaPr-oTCiWFsxFiXdCb-RYg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1291 bytes --]

On Wed, Mar 16, 2016 at 03:10:01PM +0000, Peter Maydell wrote:
> On 2 March 2016 at 10:55, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> > On Tue, Feb 23, 2016 at 07:22:07PM +0100, Lluís Vilanova wrote:
> >> NOTE: This series applies on top of "trace: Show vCPU info in guest code events"
> >>
> >> This series adds to new events:
> >>
> >> * guest_vmem: memory accesses performed by vCPUs (guest code)
> >>
> >> * guest_vmem_user_syscall: memory accesses performed by syscall emulation when
> >>   running QEMU in user-mode.
> >>
> >> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> >> ---
> >>
> >> Lluís Vilanova (5):
> >>       exec: [tcg] Track which vCPU is performing translation and execution
> >>       trace: [all] Add "guest_vmem" event
> >>       user: Refactor lock_user body into do_lock_user
> >>       user: Set current vCPU during syscall execution
> >>       trace: [all] Add "guest_vmem_user_syscall" event
> 
> > Any comments from TCG folks?
> 
> The first two patches which add TCG guest data access tracing look
> OK to me, but I'm much less sure about the last three which are
> adding tracing into linux-user syscall emulation. I'm not sure
> that lock_user is the right place to put that tracepoint.

Any thoughts on this, Lluís?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2016-03-22 12:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-23 18:22 [Qemu-devel] [PATCH 0/5] trace: Add events for vCPU memory accesses Lluís Vilanova
2016-02-23 18:22 ` [Qemu-devel] [PATCH 1/5] exec: [tcg] Track which vCPU is performing translation and execution Lluís Vilanova
2016-03-16 15:01   ` Peter Maydell
2016-02-23 18:22 ` [Qemu-devel] [PATCH 2/5] trace: [all] Add "guest_vmem" event Lluís Vilanova
2016-03-16 15:01   ` Peter Maydell
2016-03-17 19:22     ` Lluís Vilanova
2016-03-17 20:18       ` Richard Henderson
2016-03-17 20:25       ` Peter Maydell
2016-03-18 18:50         ` Lluís Vilanova
2016-03-19 13:59           ` Peter Maydell
2016-03-20 18:09             ` Lluís Vilanova
2016-03-20 19:59               ` Peter Maydell
2016-03-21 16:51                 ` Lluís Vilanova
2016-02-23 18:22 ` [Qemu-devel] [PATCH 3/5] user: Refactor lock_user body into do_lock_user Lluís Vilanova
2016-02-23 18:22 ` [Qemu-devel] [PATCH 4/5] user: Set current vCPU during syscall execution Lluís Vilanova
2016-02-23 18:22 ` [Qemu-devel] [PATCH 5/5] trace: [all] Add "guest_vmem_user_syscall" event Lluís Vilanova
2016-03-02 10:55 ` [Qemu-devel] [PATCH 0/5] trace: Add events for vCPU memory accesses Stefan Hajnoczi
2016-03-16 15:10   ` Peter Maydell
2016-03-22 12:55     ` Stefan Hajnoczi [this message]
2016-03-22 14:02       ` Lluís Vilanova
2016-03-22 14:47         ` Peter Maydell
2016-03-22 19:23           ` Lluís Vilanova
2016-03-22 20:23             ` Peter Maydell
2016-03-23 14:08               ` Lluís Vilanova

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160322125502.GH29248@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@gmail.com \
    --cc=vilanova@ac.upc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).