From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiLq3-0004Yi-88 for qemu-devel@nongnu.org; Tue, 22 Mar 2016 08:55:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiLpz-0006hH-8P for qemu-devel@nongnu.org; Tue, 22 Mar 2016 08:55:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37000) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiLpx-0006e5-9O for qemu-devel@nongnu.org; Tue, 22 Mar 2016 08:55:07 -0400 Date: Tue, 22 Mar 2016 12:55:02 +0000 From: Stefan Hajnoczi Message-ID: <20160322125502.GH29248@stefanha-x1.localdomain> References: <145625172744.12025.2350972792125742783.stgit@localhost> <20160302105553.GB11268@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vtJ+CqYNzKB4ukR4" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 0/5] trace: Add events for vCPU memory accesses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Llu=EDs?= Vilanova Cc: Peter Maydell , Stefan Hajnoczi , QEMU Developers , Richard Henderson --vtJ+CqYNzKB4ukR4 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 16, 2016 at 03:10:01PM +0000, Peter Maydell wrote: > On 2 March 2016 at 10:55, Stefan Hajnoczi wrote: > > On Tue, Feb 23, 2016 at 07:22:07PM +0100, Llu=EDs Vilanova wrote: > >> NOTE: This series applies on top of "trace: Show vCPU info in guest co= de events" > >> > >> This series adds to new events: > >> > >> * guest_vmem: memory accesses performed by vCPUs (guest code) > >> > >> * guest_vmem_user_syscall: memory accesses performed by syscall emulat= ion when > >> running QEMU in user-mode. > >> > >> Signed-off-by: Llu=EDs Vilanova > >> --- > >> > >> Llu=EDs Vilanova (5): > >> exec: [tcg] Track which vCPU is performing translation and execu= tion > >> trace: [all] Add "guest_vmem" event > >> user: Refactor lock_user body into do_lock_user > >> user: Set current vCPU during syscall execution > >> trace: [all] Add "guest_vmem_user_syscall" event >=20 > > Any comments from TCG folks? >=20 > The first two patches which add TCG guest data access tracing look > OK to me, but I'm much less sure about the last three which are > adding tracing into linux-user syscall emulation. I'm not sure > that lock_user is the right place to put that tracepoint. Any thoughts on this, Llu=EDs? --vtJ+CqYNzKB4ukR4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJW8UCmAAoJEJykq7OBq3PIyQMH/0KwQNv+g0rCx/gs+tW0pS33 DIvlBFCIyOj04B98IgxoHrRgUslPnITR3MiQd/5iTgJxFonrGykAF20YhOQ0UjI7 Qlahf2LAm1mh0KeG4MQxLrz0iRGSTyk1DvMfXY5FMegZAQJUZIYg0LEq0Iyf85/H 6TGajl27YDGczunG4f+oUvWFCQ0ollGY5p+uUkkNDoEWjHui4GVGgla/YEz5p48C gF2WHHbJeLuePbGcemIubAPuScIQ6bWDltzp1czWijZgkT5FXefi/ICz1Pxmtmhs J1/0a0tj3RObWg0G49Rkv+YbwyqOPsP00an/4gXfptHRdsY+NFyaawdViSn1kPo= =BzX8 -----END PGP SIGNATURE----- --vtJ+CqYNzKB4ukR4--