From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiS21-00061M-4D for qemu-devel@nongnu.org; Tue, 22 Mar 2016 15:31:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiS1y-0001tF-7I for qemu-devel@nongnu.org; Tue, 22 Mar 2016 15:31:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59849) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiS1y-0001sy-2J for qemu-devel@nongnu.org; Tue, 22 Mar 2016 15:31:54 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id B7CA07823F for ; Tue, 22 Mar 2016 19:31:53 +0000 (UTC) Date: Tue, 22 Mar 2016 13:31:50 -0600 From: Alex Williamson Message-ID: <20160322133150.5ba2f25f@t450s.home> In-Reply-To: References: <20160322030112.GA28183@pxdev.xzpeter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vfio: add check for memory region overflow condition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bandan Das Cc: qemu-devel , Peter Xu On Tue, 22 Mar 2016 15:07:00 -0400 Bandan Das wrote: > Peter Xu writes: > > > On Mon, Mar 21, 2016 at 06:00:50PM -0400, Bandan Das wrote: > >> > >> vfio_listener_region_add for a iommu mr results in > >> an overflow assert since emulated iommu memory region is initialized > >> with UINT64_MAX. Add a check just like memory_region_size() > >> does. > > > > Hi, Bandan, > > > > In case you missed this: > > > > https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg02865.html > > Thank you Peter, I wasn't aware. But unfortunately, I don't think he's doing the right > thing either when handing @end ? Oh well, it's a RFC :) Agree, the fix there is bogus too.