From: "Daniel P. Berrange" <berrange@redhat.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: jasowang@redhat.com, jan.kiszka@siemens.com, thuth@redhat.com,
qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6
Date: Wed, 23 Mar 2016 10:13:19 +0000 [thread overview]
Message-ID: <20160323101319.GE19338@redhat.com> (raw)
In-Reply-To: <1458473954-18583-1-git-send-email-samuel.thibault@ens-lyon.org>
On Sun, Mar 20, 2016 at 12:39:14PM +0100, Samuel Thibault wrote:
> Make net=0.0.0.0 disable IPv4 and ip6-net=:: disable IPv6, so the user can
> setup IPv4-only and IPv6-only network environments.
I really don't like this kind of magic because it is totally invisible
to the user unless they read the docs.
With the SocketAddress QAPI schema (that is exposed on the command line
via -chardev and -vnc options) we already defined a clear way to disable
IPv4/6 via boolean flags
ipv4=on|off & ipv6=on|off
when users see a boolean 'ipv6' option it is pretty clear what it can
do without needing them to read the docs. So can we just use this same
syntax for slirp too.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
prev parent reply other threads:[~2016-03-23 10:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-20 11:39 [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6 Samuel Thibault
2016-03-20 13:32 ` Samuel Thibault
2016-03-21 7:33 ` Thomas Huth
2016-03-21 7:33 ` Markus Armbruster
2016-03-21 9:02 ` Samuel Thibault
2016-03-21 9:44 ` Markus Armbruster
2016-03-21 23:55 ` Samuel Thibault
2016-03-22 7:41 ` Markus Armbruster
2016-03-22 8:02 ` Thomas Huth
2016-03-22 21:46 ` Samuel Thibault
2016-03-23 10:01 ` Markus Armbruster
2016-03-23 10:13 ` Daniel P. Berrange [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323101319.GE19338@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).