From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aifn6-0008N6-SJ for qemu-devel@nongnu.org; Wed, 23 Mar 2016 06:13:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aifn2-00044C-Kh for qemu-devel@nongnu.org; Wed, 23 Mar 2016 06:13:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36388) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aifn2-000442-F6 for qemu-devel@nongnu.org; Wed, 23 Mar 2016 06:13:24 -0400 Date: Wed, 23 Mar 2016 10:13:19 +0000 From: "Daniel P. Berrange" Message-ID: <20160323101319.GE19338@redhat.com> References: <1458473954-18583-1-git-send-email-samuel.thibault@ens-lyon.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1458473954-18583-1-git-send-email-samuel.thibault@ens-lyon.org> Subject: Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6 Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault Cc: jasowang@redhat.com, jan.kiszka@siemens.com, thuth@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On Sun, Mar 20, 2016 at 12:39:14PM +0100, Samuel Thibault wrote: > Make net=0.0.0.0 disable IPv4 and ip6-net=:: disable IPv6, so the user can > setup IPv4-only and IPv6-only network environments. I really don't like this kind of magic because it is totally invisible to the user unless they read the docs. With the SocketAddress QAPI schema (that is exposed on the command line via -chardev and -vnc options) we already defined a clear way to disable IPv4/6 via boolean flags ipv4=on|off & ipv6=on|off when users see a boolean 'ipv6' option it is pretty clear what it can do without needing them to read the docs. So can we just use this same syntax for slirp too. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|