From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aikyG-00066i-Ef for qemu-devel@nongnu.org; Wed, 23 Mar 2016 11:45:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aikyD-0006rD-7p for qemu-devel@nongnu.org; Wed, 23 Mar 2016 11:45:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58286) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aikyD-0006r3-2Y for qemu-devel@nongnu.org; Wed, 23 Mar 2016 11:45:17 -0400 Date: Wed, 23 Mar 2016 16:45:10 +0100 From: Kevin Wolf Message-ID: <20160323154510.GF4126@noname.redhat.com> References: <20160314074429.4980.34777.stgit@PASHA-ISP> <20160314074436.4980.83856.stgit@PASHA-ISP> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160314074436.4980.83856.stgit@PASHA-ISP> Subject: Re: [Qemu-devel] [PATCH v5 1/7] replay: character devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, igor.rubinov@gmail.com, mark.burton@greensocs.com, real@ispras.ru, hines@cert.org, qemu-devel@nongnu.org, maria.klimushenkova@ispras.ru, stefanha@redhat.com, pbonzini@redhat.com, batuzovk@ispras.ru, alex.bennee@linaro.org, fred.konrad@greensocs.com Am 14.03.2016 um 08:44 hat Pavel Dovgalyuk geschrieben: > This patch implements record and replay of character devices. > It records chardevs communication in replay mode. Recorded information > include data read from backend and counter of bytes written > from frontend to backend to preserve frontend internal state. > If character device was configured through the command line in record mode, > then in replay mode it should be also added to command line. Backend of > the character device could be changed in replay mode. > Replaying of devices that perform ioctl and get_msgfd operations is not > supported. > gdbstub which also acts as a backend is not recorded to allow controlling > the replaying through gdb. Monitor backends are also not recorded. > > Signed-off-by: Pavel Dovgalyuk This patch contains three lines with trailing whitespace. (Didn't actually check anything but what the patch touches, but git show marked it in red, so I couldn't not notice this.) Kevin