From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj0fd-0002W1-76 for qemu-devel@nongnu.org; Thu, 24 Mar 2016 04:31:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aj0fc-0001pT-By for qemu-devel@nongnu.org; Thu, 24 Mar 2016 04:31:09 -0400 Date: Thu, 24 Mar 2016 09:31:00 +0100 From: Kevin Wolf Message-ID: <20160324083100.GC4310@noname.redhat.com> References: <1458297067-19624-1-git-send-email-kwolf@redhat.com> <56F2F883.7000505@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="O5XBE6gyVG5Rl6Rj" Content-Disposition: inline In-Reply-To: <56F2F883.7000505@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block: Remove bdrv_make_anon() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: armbru@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org --O5XBE6gyVG5Rl6Rj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 23.03.2016 um 21:11 hat Max Reitz geschrieben: > On 18.03.2016 11:31, Kevin Wolf wrote: > > The call in hmp_drive_del() is dead code because blk_remove_bs() is > > called a few lines above. >=20 > Ah, so that's why I didn't have it in v3. Thanks for solving that > mystery for me. :-) I could have mentioned it in the review, but I figured it was quicker to just send a follow-up patch. > > The only other remaining user is > > bdrv_delete(), which only abuses bdrv_make_anon() to remove it from the > > named nodes list. This path inlines the list entry removal into > > bdrv_delete() and removes bdrv_make_anon(). > >=20 > > Signed-off-by: Kevin Wolf > > --- > > block.c | 15 +++------------ > > blockdev.c | 3 --- > > include/block/block.h | 1 - > > 3 files changed, 3 insertions(+), 16 deletions(-) >=20 > Reviewed-by: Max Reitz Thanks. Kevin --O5XBE6gyVG5Rl6Rj Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJW86XEAAoJEH8JsnLIjy/WEPwP/jxOLi4nOVbhTMmTYdLQgQsu ini2QQmtqseVBjarsy9nAb/Mv9hfPJ8Lgc1N+/N8FlPHqibrVEBWjd1ljv6vcI8Q 51smi/bt6fNCi7jn9F/vQEMLXWBl8SAxdeCiuhsUmMb9DSkZ43lFCAo33ElcZM9K rHOrb2RZwqFLajJGr684veacu79aK16qIQ3JA4tyoD+ZqBbNigheaZbFKlR1VGV6 tmWBk7SVqTrKWW6kUFt4JMWHV1qP71U0uQY3bzMxnfGvGZqI8ERa47gB0PqygRyq n3E13HxXXOaErIi+e/rpXHwZzfwoFu3rWMCGWNItSfm4ZWK6kO9O29ZgbCDl3coS koYzuHsQYobCENE3e0itAwV5Moj58xpP5EAkMZxQJt66koQf/iTdACpS30iWODLq u+AOCZBzmjewcE536RQqizdDSshxPdG5XNs9Z/gaBZlIBsRTA3xy50z3H2hUAtAq lONz1WA+TTAlwxFIJY/mEfEdvrlDpE6s/wJWWpc6V/NYkLO/Ed0J8ekjN0e8l56Y /mmDT8zVfbPmf4fPMA9yQaWWdsbUSh3ROHnFjc2AF0QKctXfEtUsVevlimxvSNQB JG13l16uV67XSW5z2mK4E+yuvXFH/I/PDJiWFctnoIdB3x+FfeOnDcsG+XX9S5aF ZUB4ItpIkV7xiv6iQSHY =Vky0 -----END PGP SIGNATURE----- --O5XBE6gyVG5Rl6Rj--