qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org,
	igor.rubinov@gmail.com, mark.burton@greensocs.com,
	real@ispras.ru, hines@cert.org, qemu-devel@nongnu.org,
	maria.klimushenkova@ispras.ru, stefanha@redhat.com,
	pbonzini@redhat.com, batuzovk@ispras.ru, alex.bennee@linaro.org,
	fred.konrad@greensocs.com
Subject: Re: [Qemu-devel] [PATCH v5 6/7] replay: fix error message
Date: Thu, 24 Mar 2016 12:56:42 +0100	[thread overview]
Message-ID: <20160324115642.GD4310@noname.redhat.com> (raw)
In-Reply-To: <20160314074504.4980.29461.stgit@PASHA-ISP>

Am 14.03.2016 um 08:45 hat Pavel Dovgalyuk geschrieben:
> This patch fixes error message in saving loop of the asynchronous events queue.
> 
> Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
> ---
>  replay/replay-events.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/replay/replay-events.c b/replay/replay-events.c
> index 4aa8034..b6b8a64 100644
> --- a/replay/replay-events.c
> +++ b/replay/replay-events.c
> @@ -175,7 +175,7 @@ static void replay_save_event(Event *event, int checkpoint)
>              replay_event_char_read_save(event->opaque);
>              break;
>          default:
> -            error_report("Unknown ID %d of replay event", read_event_kind);
> +            error_report("Unknown ID %d of replay event", event->id);

replay/replay-events.c: In function 'replay_save_event':
replay/replay-events.c:178:13: error: format '%d' expects argument of type 'int', but argument 2 has type 'uint64_t' [-Werror=format=]

Fixing this into %" PRId64 ".

Kevin

>              exit(1);
>          }
>      }
> 

  reply	other threads:[~2016-03-24 11:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14  7:44 [Qemu-devel] [PATCH v5 0/7] Deterministic replay extensions Pavel Dovgalyuk
2016-03-14  7:44 ` [Qemu-devel] [PATCH v5 1/7] replay: character devices Pavel Dovgalyuk
2016-03-14 14:11   ` Paolo Bonzini
2016-03-23 15:45   ` Kevin Wolf
2016-03-23 16:54     ` Paolo Bonzini
2016-03-14  7:44 ` [Qemu-devel] [PATCH v5 2/7] icount: remove obsolete warp call Pavel Dovgalyuk
2016-03-14  7:44 ` [Qemu-devel] [PATCH v5 3/7] icount: decouple warp calls Pavel Dovgalyuk
2016-03-14  7:44 ` [Qemu-devel] [PATCH v5 4/7] block: add flush callback Pavel Dovgalyuk
2016-03-23 15:46   ` Kevin Wolf
2016-03-14  7:44 ` [Qemu-devel] [PATCH v5 5/7] replay: bh scheduling fix Pavel Dovgalyuk
2016-03-14  7:45 ` [Qemu-devel] [PATCH v5 6/7] replay: fix error message Pavel Dovgalyuk
2016-03-24 11:56   ` Kevin Wolf [this message]
2016-03-14  7:45 ` [Qemu-devel] [PATCH v5 7/7] replay: introduce block devices record/replay Pavel Dovgalyuk
2016-03-23 15:52   ` Kevin Wolf
2016-03-15 20:04 ` [Qemu-devel] [PATCH v5 0/7] Deterministic replay extensions Igor R
2016-03-17  8:06   ` Pavel Dovgalyuk
2016-03-24 11:59 ` Kevin Wolf
2016-03-24 19:24   ` Pavel Dovgalyuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160324115642.GD4310@noname.redhat.com \
    --to=kwolf@redhat.com \
    --cc=Pavel.Dovgaluk@ispras.ru \
    --cc=alex.bennee@linaro.org \
    --cc=batuzovk@ispras.ru \
    --cc=edgar.iglesias@xilinx.com \
    --cc=fred.konrad@greensocs.com \
    --cc=hines@cert.org \
    --cc=igor.rubinov@gmail.com \
    --cc=maria.klimushenkova@ispras.ru \
    --cc=mark.burton@greensocs.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=real@ispras.ru \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).