qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@gnu.org>
To: Eric Blake <eblake@redhat.com>
Cc: jasowang@redhat.com, jan.kiszka@siemens.com, thuth@redhat.com,
	qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCHv2] slirp: Allow to disable IPv4 or IPv6
Date: Thu, 24 Mar 2016 22:44:42 +0100	[thread overview]
Message-ID: <20160324214442.GP2957@var.home> (raw)
In-Reply-To: <56F45DD3.9080103@redhat.com>

Hello,

Eric Blake, on Thu 24 Mar 2016 15:36:19 -0600, wrote:
> What happens if 'net' is provided but 'ip4' is false?  Is that a user error?

We could do that, yes.

> The existing 'InetSocketAddress' QAPI type spells these as 'ipv4' and
> ipv6'; should we use the same spelling for consistency?

Then it's inconsistent with the ip6-* options, but we can change those,
since they are still new.

> Was the intent to allow 'ip6-prefix':'none' as the special case for
> disabling IPv6?

That was the original plan, but a boolean was suggested instead.

Samuel

      parent reply	other threads:[~2016-03-24 21:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-24 21:00 [Qemu-devel] [PATCHv2] slirp: Allow to disable IPv4 or IPv6 Samuel Thibault
2016-03-24 21:36 ` Eric Blake
2016-03-24 21:41   ` Samuel Thibault
2016-03-24 21:44   ` Samuel Thibault [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160324214442.GP2957@var.home \
    --to=samuel.thibault@gnu.org \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).