From: Fam Zheng <famz@redhat.com>
To: Pooja Dhannawat <dhannawatpooja1@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4] blizzard: Remove support for DEPTH != 32
Date: Fri, 25 Mar 2016 11:09:37 +0800 [thread overview]
Message-ID: <20160325030937.GG29171@ad.usersys.redhat.com> (raw)
In-Reply-To: <1458843489-14104-1-git-send-email-dhannawatpooja1@gmail.com>
On Thu, 03/24 23:48, Pooja Dhannawat wrote:
> Removing support for DEPTH != 32 from blizzard template header
> and file that includes it, as macro DEPTH == 32 only used.
>
> Signed-off-by: Pooja Dhannawat <dhannawatpooja1@gmail.com>
Hi Pooja, a meta-comment: in the future, when post a subsequent revision,
please include what is changed since previous revision, in the cover letter if
there are multiple patches, or under a "---" line in the commit message if
there is no cover letter. (Remember that the Signed-off-by line must still stay
above the "---" line).
The reason to use "---" line is for maintainers to avoid "git am" applying the
revision changelog into git history (apparently it is meaningless out of patch
review context).
In this case, it would be like:
----8<---
Removing support for DEPTH != 32 from blizzard template header
and file that includes it, as macro DEPTH == 32 only used.
Signed-off-by: Pooja Dhannawat <dhannawatpooja1@gmail.com>
---
v4: Changed foo to bar, and baz to qux. [$name_of_suggester]
---->8---
next prev parent reply other threads:[~2016-03-25 3:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 18:18 [Qemu-devel] [PATCH v4] blizzard: Remove support for DEPTH != 32 Pooja Dhannawat
2016-03-24 19:03 ` Eric Blake
2016-03-25 3:09 ` Fam Zheng [this message]
2016-03-25 6:06 ` Pooja Dhannawat
-- strict thread matches above, loose matches on Subject: below --
2016-03-26 5:57 Pooja Dhannawat
2016-04-05 6:54 ` Pooja Dhannawat
2016-05-04 14:13 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160325030937.GG29171@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=dhannawatpooja1@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).