From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajI89-0001H7-PO for qemu-devel@nongnu.org; Thu, 24 Mar 2016 23:09:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ajI84-0003HJ-PN for qemu-devel@nongnu.org; Thu, 24 Mar 2016 23:09:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51599) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajI84-0003HF-K5 for qemu-devel@nongnu.org; Thu, 24 Mar 2016 23:09:40 -0400 Date: Fri, 25 Mar 2016 11:09:37 +0800 From: Fam Zheng Message-ID: <20160325030937.GG29171@ad.usersys.redhat.com> References: <1458843489-14104-1-git-send-email-dhannawatpooja1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458843489-14104-1-git-send-email-dhannawatpooja1@gmail.com> Subject: Re: [Qemu-devel] [PATCH v4] blizzard: Remove support for DEPTH != 32 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pooja Dhannawat Cc: qemu-devel@nongnu.org On Thu, 03/24 23:48, Pooja Dhannawat wrote: > Removing support for DEPTH != 32 from blizzard template header > and file that includes it, as macro DEPTH == 32 only used. > > Signed-off-by: Pooja Dhannawat Hi Pooja, a meta-comment: in the future, when post a subsequent revision, please include what is changed since previous revision, in the cover letter if there are multiple patches, or under a "---" line in the commit message if there is no cover letter. (Remember that the Signed-off-by line must still stay above the "---" line). The reason to use "---" line is for maintainers to avoid "git am" applying the revision changelog into git history (apparently it is meaningless out of patch review context). In this case, it would be like: ----8<--- Removing support for DEPTH != 32 from blizzard template header and file that includes it, as macro DEPTH == 32 only used. Signed-off-by: Pooja Dhannawat --- v4: Changed foo to bar, and baz to qux. [$name_of_suggester] ---->8---