From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36217)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1akMku-0008PJ-Q4
	for qemu-devel@nongnu.org; Sun, 27 Mar 2016 22:18:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1akMkp-0000O7-QH
	for qemu-devel@nongnu.org; Sun, 27 Mar 2016 22:18:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33299)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1akMkp-0000O1-Kj
	for qemu-devel@nongnu.org; Sun, 27 Mar 2016 22:18:07 -0400
Date: Mon, 28 Mar 2016 10:18:00 +0800
From: Peter Xu <peterx@redhat.com>
Message-ID: <20160328021800.GJ28183@pxdev.xzpeter.org>
References: <1458872009-13342-1-git-send-email-jasowang@redhat.com>
	<1458872009-13342-5-git-send-email-jasowang@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1458872009-13342-5-git-send-email-jasowang@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 4/8] exec: introduce
	address_space_get_iotlb_entry()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Wang <jasowang@redhat.com>
Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com>, mst@redhat.com, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, pbonzini@redhat.com, Richard Henderson <rth@twiddle.net>

On Fri, Mar 25, 2016 at 10:13:25AM +0800, Jason Wang wrote:
> This patch introduces a helper to query the iotlb entry for a
> possible iova. This will be used by later device IOTLB API to enable
> the capability for a dataplane (e.g vhost) to query the IOTLB.
> 
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
>  exec.c                | 30 ++++++++++++++++++++++++++++++
>  include/exec/memory.h |  7 +++++++
>  2 files changed, 37 insertions(+)
> 
> diff --git a/exec.c b/exec.c
> index f398d21..31fac9f 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -411,6 +411,36 @@ address_space_translate_internal(AddressSpaceDispatch *d, hwaddr addr, hwaddr *x
>  }
>  
>  /* Called from RCU critical section */
> +IOMMUTLBEntry address_space_get_iotlb_entry(AddressSpace *as, hwaddr addr,
> +                                            bool is_write)
> +{
> +    IOMMUTLBEntry iotlb = {0};
> +    MemoryRegionSection *section;
> +    MemoryRegion *mr;
> +    hwaddr plen;
> +
> +    for (;;) {
> +        AddressSpaceDispatch *d = atomic_rcu_read(&as->dispatch);
> +        section = address_space_translate_internal(d, addr, &addr, &plen, true);
> +        mr = section->mr;
> +
> +        if (!mr->iommu_ops) {
> +            break;
> +        }
> +
> +        iotlb = mr->iommu_ops->translate(mr, addr, is_write);
> +        if (!(iotlb.perm & (1 << is_write))) {
> +            iotlb.target_as = NULL;
> +            break;
> +        }

Here, do we still need something like:

        addr = ((iotlb.translated_addr & ~iotlb.addr_mask)
                | (addr & iotlb.addr_mask));

Just as address_space_translate() does? Now "addr" should be the
offset in memory region "mr", while we need it to be the offset in
address space if there are more loops, right?

Also, not sure whether we can abstract a shared function out of this
function and address_space_translate().

Thanks.

-- peterx