From: Samuel Thibault <samuel.thibault@gnu.org>
To: Eric Blake <eblake@redhat.com>
Cc: jasowang@redhat.com, jan.kiszka@siemens.com, thuth@redhat.com,
qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCHv4 2/2] slirp: Allow disabling IPv4 or IPv6
Date: Tue, 29 Mar 2016 01:46:12 +0200 [thread overview]
Message-ID: <20160328234612.GB3694@var.home> (raw)
In-Reply-To: <56F949C4.3070302@redhat.com>
Eric Blake, on Mon 28 Mar 2016 09:12:04 -0600, wrote:
> > + if ((user->has_ipv6 && user->ipv6 && !user->has_ipv4)
> > + || (user->has_ipv4 && !user->ipv4))
> > + ipv4 = 0;
>
> Inconsistent with current qemu style. Should be:
>
> if ((user->has_ipv6 && user->ipv6 && !user->has_ipv4) ||
> (user->has_ipv4 && !user->ipv4)) {
Ah, I didn't know about that one. I personally prefer it the other way,
but alright.
> In particular, the missing {} (should) fail ./scripts/checkpatch.pl.
Right, sorry, it seems I forgot to re-run the script after the last
rework.
Samuel
prev parent reply other threads:[~2016-03-28 23:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 23:34 [Qemu-devel] [PATCHv4 0/2] Rework ipv6 options, add ipv4/ipv6 enabling/disabling options Samuel Thibault
2016-03-24 23:34 ` [Qemu-devel] [PATCHv4 1/2] Rework ipv6 options Samuel Thibault
2016-03-28 15:00 ` Eric Blake
2016-03-24 23:34 ` [Qemu-devel] [PATCHv4 2/2] slirp: Allow disabling IPv4 or IPv6 Samuel Thibault
2016-03-28 15:12 ` Eric Blake
2016-03-28 23:46 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160328234612.GB3694@var.home \
--to=samuel.thibault@gnu.org \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).